IBX-6773: Aligned Bookmarks loadBookmarks call with Repository filtering requirements#1835
Open
vidarl wants to merge 1 commit into
Open
IBX-6773: Aligned Bookmarks loadBookmarks call with Repository filtering requirements#1835vidarl wants to merge 1 commit into
loadBookmarks call with Repository filtering requirements#1835vidarl wants to merge 1 commit into
Conversation
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception
branch
from
7ed1bfc to
0492914
Compare
|
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
Contributor
Author
|
Tests fail due to security advisory on richtext dependency, discussed on php-team channel on slack : https://ibexa.slack.com/archives/C06GPEY4542/p1771401650317669 |
alongosz
changed the title
loadBookmarks call with Repository filtering requirements
konradoboza
reviewed
Mar 10, 2026
konradoboza
left a comment
konradoboza
left a comment
Contributor
There was a problem hiding this comment.
Is any change needed here? Since we are introducing filtering, $limit will be ignored anyway, or?
Contributor
Author
|
I don't follow you. What do you mean by ignored? Filtering also supports |
Contributor
|
Yeah, I missed some collapsed code in the Github UI 🙈, disregard. |
konradoboza
approved these changes
Mar 10, 2026
Steveb-p
approved these changes
Mar 10, 2026
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception
branch
from
0492914 to
889bb75
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Related PRs:
Description:
In ibexa/core#476, Bookmark service was changed to use Filter where no-limit is specified by value
0, not-1For QA:
Documentation: