IBX-11423: added optional parameter to urlAliasService:load() call.#1864
IBX-11423: added optional parameter to urlAliasService:load() call.#1864papcio122 wants to merge 2 commits into
Conversation
papcio122
force-pushed
the
IBX-11423_cant-delete-product-urlalias-for-translations
branch
from
ad0b679 to
202f807
Compare
papcio122
force-pushed
the
IBX-11423_cant-delete-product-urlalias-for-translations
branch
from
19bd33d to
e6bc0ef
Compare
|
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
Why such change? It seems unrelated to products at first glance, why targeting AdminUI?
The issue is not only related to products - I updated the ticket and PR description. When loading a list of aliases to remove in Ibexa\Bundle\AdminUi\Controller\UrlAliasController::removeAction(), the service loads only aliases in the default language; the aliases for translations can't be removed. Changed the call to service so it loads aliases in all languages, so the aliases for translations are also getting added to the remove list. |
6 participants
Related PRs:
Description:
When loading a list of aliases to remove in Ibexa\Bundle\AdminUi\Controller\UrlAliasController::removeAction(), the service loads only aliases in the default language and no aliases for translations, thus the aliases for translations can't be removed.
Changed the call to service so it loads aliases in all languages, so the aliases for translations are also getting added to the remove list.
Used the optional parameter $showAllTranslations to URLAliasService::load() when deleting URLAlias, which allowed the deletion of URLAlias for translations of contents.