IBX-11413: Use design-system dropdown component#1902
Open
tischsoic wants to merge 23 commits into
Open
Conversation
dew326
approved these changes
May 15, 2026
tischsoic
force-pushed
the
IBX-11413-use-ds-dropdown
branch
2 times, most recently
from
4f5430d to
8193ee5
Compare
tischsoic
force-pushed
the
IBX-11413-use-ds-dropdown
branch
from
8193ee5 to
c41218f
Compare
albozek
reviewed
Jun 3, 2026
| }; | ||
| const attachFieldDefinitionNodeEvents = (fieldNode, { targetContainer }) => { | ||
| const initDropdown = (dropdownContainer) => { | ||
| const dropdownAlreadyInitialized = !!ibexa.helpers.objectInstances.getInstance(dropdownContainer); |
Contributor
There was a problem hiding this comment.
Suggested change
| const dropdownAlreadyInitialized = !!ibexa.helpers.objectInstances.getInstance(dropdownContainer); | |
| const isDropdownAlreadyInitialized = !!ibexa.helpers.objectInstances.getInstance(dropdownContainer); |
Contributor
Author
There was a problem hiding this comment.
This code was just moved from
dropdowns.forEach((dropdownContainer) => {
const dropdownAlreadyInitialized = !!ibexa.helpers.objectInstances.getInstance(dropdownContainer);
I preserved the old variable name and logic.
| disabled: is_disabled, | ||
| required: required|default(false), | ||
| }) %} | ||
| {% set normalized_source_attr = source_id is not null |
Contributor
There was a problem hiding this comment.
Nitpick, since second option is now assigning the same value but it's your call.
Suggested change
| {% set normalized_source_attr = source_id is not null | |
| {% if source_id is not null %} | |
| {% set normalized_source_attr = normalized_source_attr|merge({ id: source_id }) %} | |
| {% endif %} |
| source, | ||
| sourceAttributes: normalized_source_attr, | ||
| } %} | ||
| {% set ds_dropdown_props = translated_placeholder is not same as(null) |
KamilSznajdrowicz
force-pushed
the
IBX-11413-use-ds-dropdown
branch
from
c41218f to
3f5f8e4
Compare
This reverts commit 9eaad2c.
tischsoic
force-pushed
the
IBX-11413-use-ds-dropdown
branch
from
3f5f8e4 to
1f7c8fa
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: