IBX-11780: Integrated ContentPublicationStrategyInterface into ContentFormProcessor publish flow#113
Draft
bnowak wants to merge 1 commit into
Conversation
…tFormProcessor publish flow, replaced content payload with content_type and covered processPublish with unit tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description:
ContentFormProcessor::processPublish()now publishes throughContentPublicationStrategyInterface(ibexa/core) instead of callingContentService::publishVersion()directly. The strategy chain resolves to the synchronous strategy by default, or to the asynchronous one (ibexa/async-content-publishing) when asynchronous content publishing is enabled.The strategy returns a
ContentPublicationResultwhosepublishedContentisnullon the asynchronous path, therefore:contentevent payload was replaced withcontent_type(derived from the draft) — payload consumers are adjusted in the ibexa/dashboard and ibexa/admin-ui counterpart PRs,locationId = null(the proper redirection target for this case is a TODO handled separately).The synchronous path behaves exactly as before.
processPublish()is now covered with unit tests (strategy invocation, payload contract, sync/async redirect matrix,redirectUrlAfterPublishoverride).For QA:
Documentation:
Part of the IBX-11780 asynchronous content publishing epic — editor-facing behaviour (non-blocking publish) is documented at the epic level; nothing separate to document for this PR.