IBX-11423: added optional parameter $showAllTranslations to URLAliasS…#740
Open
papcio122 wants to merge 1 commit into
Open
IBX-11423: added optional parameter $showAllTranslations to URLAliasS…#740papcio122 wants to merge 1 commit into
papcio122 wants to merge 1 commit into
Conversation
papcio122
force-pushed
the
IBX-11423_cant-delete-product-urlalias-for-translations
branch
from
d77c911 to
062cc64
Compare
papcio122
force-pushed
the
IBX-11423_cant-delete-product-urlalias-for-translations
branch
from
062cc64 to
7c7220c
Compare
|
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
requested changes
Apr 8, 2026
konradoboza
left a comment
konradoboza
left a comment
Contributor
There was a problem hiding this comment.
How is this fixing the issue for products? There is no explanation that will help reviewing such change not mentioning lack of any tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Added optional parameter $showAllTranslations to URLAliasService::load()
In Ibexa\Bundle\AdminUi\Controller\UrlAliasController::removeAction(), the service is used to load aliases to be removed, but it returns only the aliases for the default language. Added the optional parameter to use in the related PR to load aliases for all languages when creating a list of aliases to remove.