IBX-11818: added fallback to null value when key 'timestamp' not exists in $value->data array#757
Open
papcio122 wants to merge 5 commits into
Open
IBX-11818: added fallback to null value when key 'timestamp' not exists in $value->data array#757papcio122 wants to merge 5 commits into
papcio122 wants to merge 5 commits into
Conversation
…ts in $value->data array
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
requested changes
Jun 3, 2026
papcio122
force-pushed
the
IBX-11818_empty_ibexa_datetime-field-causing-error
branch
from
22e8d03 to
f08a3f5
Compare
konradoboza
reviewed
Jun 9, 2026
| * @group fieldType | ||
| * @group dateTime | ||
| */ | ||
| public function testToStorageValueNoTimestampKey(): void |
Contributor
There was a problem hiding this comment.
We should also test if dataInt is properly populated with the timestamp if it exists.
Contributor
Author
There was a problem hiding this comment.
There is such a test a few lines earlier on line 47
Contributor
There was a problem hiding this comment.
I referred to the actual usage of timestamp key which is in the condition in question. How is it covered?
ViniTou
approved these changes
Jun 9, 2026
| @@ -32,7 +32,7 @@ public function toStorageValue(FieldValue $value, StorageFieldValue $storageFiel | |||
| { | |||
| // @todo: One should additionally store the timezone here. This could | |||
Contributor
There was a problem hiding this comment.
If we are SO CLOSE to this. Can we drop that comment? ;)
Contributor
Author
There was a problem hiding this comment.
Should I just remove it?
Or somehow store the timezone here? 😅
barw4
approved these changes
Jun 9, 2026
alongosz
reviewed
Jun 9, 2026
Comment on lines
+87
to
+122
| /** | ||
| * @group fieldType | ||
| * @group dateTime | ||
| */ | ||
| public function testToStorageValueNoTimestampKey(): void | ||
| { | ||
| $value = new FieldValue(); | ||
| $value->data = [ | ||
| 'current_time' => $this->date->getTimestamp(), | ||
| 'rfc850' => $this->date->format(DateTime::RFC850), | ||
| ]; | ||
| $value->sortKey = $this->date->getTimestamp(); | ||
| $storageFieldValue = new StorageFieldValue(); | ||
|
|
||
| $this->converter->toStorageValue($value, $storageFieldValue); | ||
| self::assertNull($storageFieldValue->dataInt); | ||
| self::assertSame($value->sortKey, $storageFieldValue->sortKeyInt); | ||
| self::assertSame('', $storageFieldValue->sortKeyString); | ||
| } | ||
|
|
||
| /** | ||
| * @group fieldType | ||
| * @group dateTime | ||
| */ | ||
| public function testToStorageValueValueDataNull(): void | ||
| { | ||
| $value = new FieldValue(); | ||
| $value->data = null; | ||
| $value->sortKey = $this->date->getTimestamp(); | ||
| $storageFieldValue = new StorageFieldValue(); | ||
|
|
||
| $this->converter->toStorageValue($value, $storageFieldValue); | ||
| self::assertNull($storageFieldValue->dataInt); | ||
| self::assertSame($value->sortKey, $storageFieldValue->sortKeyInt); | ||
| self::assertSame('', $storageFieldValue->sortKeyString); | ||
| } |
Member
There was a problem hiding this comment.
If I see it right, the only difference for these tests is an assignment of $value->data. Can this be a data provider?
konradoboza
reviewed
Jun 9, 2026
| self::assertSame($storageFieldValue->sortKeyInt, $fieldValue->sortKey); | ||
| } | ||
|
|
||
| public function providerForTestToStorageValueMissingData() |
Contributor
There was a problem hiding this comment.
Please provide a proper return type and PHPStan array shape.
Comment on lines
+91
to
+94
| [ | ||
| 'current_time' => 1048633200, | ||
| 'rfc850' => 'Thu, 01 Jan 2003 00:00:00 GMT', | ||
| ], |
Contributor
There was a problem hiding this comment.
Do we need to wrap it in several arrays?
papcio122
force-pushed
the
IBX-11818_empty_ibexa_datetime-field-causing-error
branch
from
b96fb48 to
b95c1c6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
\Ibexa\Core\Persistence\Legacy\Content\FieldValue\Converter\DateAndTimeConverter:toStorageValue()
throws an error of a missing array key when the content was created before the field was added to the content type.
Added fallback to null when the data array has no 'timestamp' key