Correctly implemented continue-on-error (#3205)

* Correctly implemented continue-on-error

* Fixed issues

* Updated baseline

Author: mnocon

.github/workflows/code_samples.yaml

@@ -60,16 +60,26 @@ jobs:
                   dependency-versions: highest
 
             - name: Run PHPStan analysis
+              id: phpstan
               continue-on-error: true
               run: composer phpstan
 
             - if: matrix.php == '8.4' # ibexa/rector supports PHP 8.3 and higher
+              id: rector
               name: Run Rector check
               continue-on-error: true
               run: |
                 composer require --dev ibexa/rector:~4.6.x-dev
                 composer check-rector
 
+            - name: Fail job if any check failed
+              if: always()
+              run: |
+                  if [[ "${{ steps.phpstan.outcome }}" == "failure" || "${{ steps.rector.outcome }}" == "failure" ]]; then
+                      echo "One or more checks failed: PHPStan=${{ steps.phpstan.outcome }}, Rector=${{ steps.rector.outcome }}"
+                      exit 1
+                  fi
+
     code-samples-inclusion-check:
         name: Check code samples inclusion
         runs-on: ubuntu-latest

phpstan-baseline.neon

@@ -156,18 +156,6 @@ parameters:
 			count: 1
 			path: code_samples/api/rest_api/create_image.xml.php
 
-		-
-			message: '#^Result of && is always false\.$#'
-			identifier: booleanAnd.alwaysFalse
-			count: 1
-			path: code_samples/api/rest_api/create_image.xml.php
-
-		-
-			message: '#^Strict comparison using \=\=\= between ''ErrorMessage'' and ''Content'' will always evaluate to false\.$#'
-			identifier: identical.alwaysFalse
-			count: 1
-			path: code_samples/api/rest_api/create_image.xml.php
-
 		-
 			message: '#^Method App\\Rest\\Output\\ValueObjectVisitorDispatcher\:\:__construct\(\) has parameter \$visitors with no value type specified in iterable type iterable\.$#'
 			identifier: missingType.iterableValue