Skip to content

[Discounts] Configuration#2781

Merged
adriendupuis merged 5 commits into
discounts-restfrom
discounts-configuration
Jun 16, 2025
Merged

[Discounts] Configuration#2781
adriendupuis merged 5 commits into
discounts-restfrom
discounts-configuration

Conversation

@mnocon

@mnocon mnocon commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

This PR extracts the Discounts configuration, describing options from:

and the previously described pagination options.

@mnocon mnocon force-pushed the discounts-configuration branch from de5af4e to f2104e8 Compare June 10, 2025 16:57
@github-actions

github-actions Bot commented Jun 10, 2025

Copy link
Copy Markdown

Preview of modified files

Preview of modified Markdown:

@mnocon mnocon force-pushed the discounts-configuration branch from b3ca350 to 03e08d8 Compare June 11, 2025 06:37
@mnocon mnocon marked this pull request as ready for review June 11, 2025 06:40
@mnocon mnocon requested review from Steveb-p and konradoboza June 11, 2025 06:40
@mnocon mnocon requested a review from a team June 11, 2025 07:12
@ezrobot ezrobot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team June 11, 2025 07:12
@mnocon mnocon force-pushed the discounts-configuration branch from 03e08d8 to eb9047b Compare June 11, 2025 07:54
@mnocon mnocon force-pushed the discounts-configuration branch from eb9047b to 09fed3a Compare June 11, 2025 11:10

@adriendupuis adriendupuis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor grammar and var usage (I'm pretty sure [[[= var =]]](url) case was previously studied before as working) to fix but approvable as a whole

Comment thread docs/discounts/configure_discounts.md Outdated
Comment thread docs/discounts/install_discounts.md Outdated
mnocon and others added 2 commits June 13, 2025 10:02
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
# Conflicts:
#	docs/discounts/discounts.md
#	mkdocs.yml
@adriendupuis adriendupuis merged commit 78781df into discounts-rest Jun 16, 2025
7 checks passed
@adriendupuis adriendupuis deleted the discounts-configuration branch June 16, 2025 08:26
adriendupuis added a commit that referenced this pull request Jun 16, 2025
* [Discounts] Described Discounts API (#2783)
* [Discounts] Configuration (#2781)

---------

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
adriendupuis added a commit that referenced this pull request Jun 16, 2025
* [Discounts] Described Discounts API (#2783)
* [Discounts] Configuration (#2781)

---------

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants