Added instructions on how to generate PEM keypair, needed by JWT authentication#2812
Merged
Conversation
Preview of modified filesPreview of modified Markdown: |
vidarl
changed the title
mnocon
reviewed
Jul 9, 2025
mnocon
reviewed
Jul 9, 2025
mnocon
left a comment
mnocon
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of small suggestions, thank you Vidar for creating this PR!
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
Contributor
Author
|
@mnocon : FYI, I am back from vacation and have finally approved your suggestions |
ezrobot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
mnocon
added a commit
that referenced
this pull request
Aug 5, 2025
…entication (#2812) * Added instructions on how to generate key pair for JWT authentication * Apply suggestions from code review Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com> --------- Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A4.6The current instructions are incomplete, ref https://symfony.com/bundles/LexikJWTAuthenticationBundle/current/index.html#generate-the-ssl-keys
Checklist