Add information about ValueObject replacement#2847
Merged
Conversation
Preview of modified filesPreview of modified Markdown: |
Steveb-p
approved these changes
Jul 23, 2025
julitafalcondusza
approved these changes
Jul 24, 2025
mnocon
approved these changes
Jul 24, 2025
mnocon
left a comment
mnocon
left a comment
Contributor
There was a problem hiding this comment.
Thank you! I suggest to convert the filepaths to FQCN (class names with the full namespace)
adriendupuis
left a comment
adriendupuis
left a comment
Contributor
There was a problem hiding this comment.
Good information.
It's already good.
It can be improved now, or it could be merged as-is and improved in a latter second pass.
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
dabrt
commented
Jul 24, 2025
adriendupuis
approved these changes
Jul 24, 2025
dabrt
added a commit
that referenced
this pull request
Jul 24, 2025
* Add information about ValueObject replacement --------- Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add information about ValueObject replacement
Checklist