Unified admonitions#3208
Merged
Merged
Conversation
|
dabrt
approved these changes
May 18, 2026
Contributor
There was a problem hiding this comment.
This file is not exposed in our table of contents. I know it was left behind to support some of our clients that used SS-based perso, but do we need it any more?
https://doc.ibexa.co/en/latest/personalization/legacy_recommendation_api/
Contributor
Author
There was a problem hiding this comment.
Let's keep it for now, at some point we'll rework the whole Personalization section
mnocon
added a commit
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Target: v5, 4.6
Our admonition usage is not consistent, we have a couple of these which compete with each other - and the
warningandinfoones use default MkDocs styling, not our custom one.In this PR, I'm converting:
info->notewarning->cautionAfter this change, the usage is:
As a follow up, I'll add a vale rule checking these, to make sure we stay consistent.