[PHP] Migrated include_file to include_code. Added remove_indent for partial includes#3209
Merged
Conversation
ibexa-workflow-automation-1
Bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
|
dabrt
approved these changes
May 18, 2026
Contributor
|
The indent removal seems to be working OK. |
Contributor
Author
Yes, that's exactly why I didn't touch them in this PR - for them, each usage has to be carefully checked and the indent level must be adjusted manually to fit the whole code sample. I've decided that it's not worth covering in this PR, we might do a follow-up in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target: v5
For PHP code samples, In code blocks with only a single include_file call:
Multiple include_* calls within a single code blocks are not covered here, as they require more attention and will be done in a follow-up
To review this, please use HTML report I've attached on Slack - this makes the review much easier.
It contains the changes before and after, and a diff showing what has changed.
Please use the provided HTML file for reviewing - it's generated locally using the existing code samples usage job, this should make the review easier.