SecurityEvents::INTERACTIVE_LOGIN → AuthenticationTokenCreatedEvent#3243
Merged
Conversation
Preview of modified filesPreview of modified Markdown: |
# Conflicts: # deptrac.baseline.yaml
konradoboza
reviewed
Jun 9, 2026
adriendupuis
commented
Jun 9, 2026
adriendupuis
commented
Jun 9, 2026
adriendupuis
commented
Jun 9, 2026
| } | ||
| //$event->getAuthenticationToken()->setUser(new User($ibexaUser)); | ||
| $event->getAuthenticationToken()->setUser(new UserWrapped($tokenUser, $ibexaUser)); | ||
| $token->setUser(new UserWrapped($tokenUser, $ibexaUser)); |
Contributor
Author
There was a problem hiding this comment.
@konradoboza Did you mean something like this?:
Suggested change
| $token->setUser(new UserWrapped($tokenUser, $ibexaUser)); | |
| $this->permissionResolver->setCurrentUserReference($ibexaUser); | |
| $token->setUser(new UserWrapped($tokenUser, $ibexaUser)); |
(after injecting the PermissionResolver in constructor as well)
Contributor
There was a problem hiding this comment.
Well, I am not sure about the priority. It would be good to check if this comes before OnAuthenticationTokenCreatedRepositoryUserSubscriber so setting the repository user isn't needed here as it will be done anyway.
code_samples/ change report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: #3087
Preview: https://ez-systems-developer-documentation--3243.com.readthedocs.build/en/3243/users/user_authentication/
Checklist