-
Notifications
You must be signed in to change notification settings - Fork 81
SecurityEvents::INTERACTIVE_LOGIN → AuthenticationTokenCreatedEvent #3243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+27
−20
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
929ff6f
SecurityEvents::INTERACTIVE_LOGIN → AuthenticationTokenCreatedEvent
adriendupuis 2aa888f
Merge branch 'user_auth_5.0' into user_auth_5.0-alt2
adriendupuis 152729f
Fix deptrac
adriendupuis 4eed19b
Merge branch 'user_auth_5.0' into user_auth_5.0-alt2
adriendupuis d7de84e
Fix deptrac
adriendupuis 2e39549
Apply suggestion from @adriendupuis
adriendupuis f3f7786
AuthenticationTokenCreatedSubscriber: facto, clean-up
adriendupuis 32693c6
Apply suggestion from @adriendupuis
adriendupuis 1d35a77
AuthenticationTokenCreatedSubscriber: increase priority
adriendupuis 1f7e81c
user_authentication.md: about priority
adriendupuis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@konradoboza Did you mean something like this?:
(after injecting the
PermissionResolverin constructor as well)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I am not sure about the priority. It would be good to check if this comes before
OnAuthenticationTokenCreatedRepositoryUserSubscriberso setting the repository user isn't needed here as it will be done anyway.