Skip to content

Fixed card link when using MkDocs development server #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mnocon wants to merge 1 commit into
base: 5.0
Choose a base branch
from
Open

Fixed card link when using MkDocs development server #3325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
from mkdocs.utils import meta
from typing import List

def _absolute_page_url(site, language, version, *parts):
return 'https://' + '/'.join((site, language, version) + parts)
def _absolute_page_url(scheme, site, language, version, *parts):
return scheme + '://' + '/'.join((site, language, version) + parts)


CARDS_TEMPLATE = """
Expand Down Expand Up @@ -74,8 +74,8 @@ def cards(pages, columns=1, style="cards", force_version=False):
current_page = env.variables.page
absolute_url = current_page.abs_url
canonical = current_page.canonical_url
url_parts = re.search("//([^/]+)/([^/]+)/([^/]+)/", canonical)
(site, language, version) = url_parts.groups()
url_parts = re.search(r"^(https?)://([^/]+)/([^/]+)/([^/]+)/", canonical)
(scheme, site, language, version) = url_parts.groups()

version = force_version or version
version = os.getenv("READTHEDOCS_VERSION_NAME", version)
Expand Down Expand Up @@ -113,12 +113,12 @@ def cards(pages, columns=1, style="cards", force_version=False):
elif re.search(".html$", path):
html = True
content = open("docs/%s" % path, "r").read()
page = _absolute_page_url(site, language, version, page)
page = _absolute_page_url(scheme, site, language, version, page)
else:
html = False
path = path.rstrip('/')
content = open("docs/%s.md" % path, "r").read()
page = _absolute_page_url(site, language, version, path, hash)
page = _absolute_page_url(scheme, site, language, version, path, hash)

if html:
match = re.search("<meta property=\"og:title\" content=\"(.*)\"", content, re.MULTILINE)
Expand Down
Loading