IBX-11714: Custom class can not be added on ul and ol elements#318
Open
OstafinL wants to merge 1 commit into
Open
IBX-11714: Custom class can not be added on ul and ol elements#318OstafinL wants to merge 1 commit into
OstafinL wants to merge 1 commit into
Conversation
OstafinL
force-pushed
the
IBX-11714-custom-class-can-not-be-added-on-ul-and-ol-elements
branch
6 times, most recently
from
50438bc to
7b67fd6
Compare
OstafinL
force-pushed
the
IBX-11714-custom-class-can-not-be-added-on-ul-and-ol-elements
branch
from
7b67fd6 to
dfe99b5
Compare
|
ibexa-workflow-automation-1
Bot
requested review from
GrabowskiM,
albozek,
alekmick,
dew326 and
tischsoic
and removed request for
a team
tischsoic
approved these changes
Jun 1, 2026
GrabowskiM
reviewed
Jun 9, 2026
Comment on lines
+88
to
+92
| if (schema.getDefinition('$listItem')) { | ||
| schema.extend('$listItem', { allowAttributes: `list-${attributeName}` }); | ||
| } else { | ||
| schema.extend('$block', { allowAttributes: `list-${attributeName}` }); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (schema.getDefinition('$listItem')) { | |
| schema.extend('$listItem', { allowAttributes: `list-${attributeName}` }); | |
| } else { | |
| schema.extend('$block', { allowAttributes: `list-${attributeName}` }); | |
| } | |
| const elementName = schema.getDefinition('$listItem') ? '$listItem' : '$block'; | |
| schema.extend(elementName { allowAttributes: `list-${attributeName}` }); |
up to you :)
| const elementSiblings = [element]; | ||
| const matchesSibling = | ||
| siblingsName === 'listItem' | ||
| ? (item) => item?.hasAttribute?.('listItemId') || item?.name === 'listItem' |
| findElementSiblings(element, siblingsName) { | ||
| let iterator = element; | ||
| const elementSiblings = [element]; | ||
| const matchesSibling = |
Contributor
There was a problem hiding this comment.
proposal: hasMatchingSibling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: