adjusted spec test cases, regenerated baseline

konradoboza · konradoboza · commit 67c22f39154f · 2026-04-01T12:45:19.000+02:00
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -1062,42 +1062,6 @@ parameters:
 			count: 1
 			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
 
-		-
-			message: '#^Method FOS\\HttpCache\\ResponseTagger\:\:addTags\(\) invoked with 0 parameters, 1 required\.$#'
-			identifier: arguments.count
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\ContentInfoTaggerSpec\:\:it_ignores_non_content_info\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\ContentInfoTaggerSpec\:\:it_is_initializable\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\ContentInfoTaggerSpec\:\:it_tags_with_content_and_content_type_id\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\ContentInfoTaggerSpec\:\:it_tags_with_location_id_if_one_is_set\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\ContentInfoTaggerSpec\:\:let\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
 		-
 			message: '#^Call to an undefined method FOS\\HttpCache\\ResponseTagger\:\:shouldHaveBeenCalled\(\)\.$#'
 			identifier: method.notFound
@@ -1122,42 +1086,6 @@ parameters:
 			count: 1
 			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
 
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\LocationTaggerSpec\:\:it_ignores_non_location\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\LocationTaggerSpec\:\:it_is_initializable\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\LocationTaggerSpec\:\:it_tags_with_location_id_if_not_main_location\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\LocationTaggerSpec\:\:it_tags_with_parent_location_id\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\LocationTaggerSpec\:\:it_tags_with_path_items\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
-		-
-			message: '#^Method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\LocationTaggerSpec\:\:let\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
 		-
 			message: '#^Parameter \#1 \$tags of method FOS\\HttpCache\\ResponseTagger\:\:addTags\(\) expects array\<string\>, Prophecy\\Argument\\Token\\AnyValueToken given\.$#'
 			identifier: argument.type
diff --git a/spec/ResponseTagger/Value/ContentInfoTaggerSpec.php b/spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
@@ -3,30 +3,32 @@
 namespace spec\Ibexa\HttpCache\ResponseTagger\Value;
 
 use Ibexa\Contracts\Core\Repository\Values\Content\ContentInfo;
+use Ibexa\Core\Repository\Values\Content\Location;
 use Ibexa\HttpCache\ResponseTagger\Value\ContentInfoTagger;
 use FOS\HttpCache\ResponseTagger;
 use PhpSpec\ObjectBehavior;
+use RuntimeException;
 
 class ContentInfoTaggerSpec extends ObjectBehavior
 {
-    public function let(ResponseTagger $tagHandler)
+    public function let(ResponseTagger $tagHandler): void
     {
         $this->beConstructedWith($tagHandler);
     }
 
-    public function it_is_initializable()
+    public function it_is_initializable(): void
     {
         $this->shouldHaveType(ContentInfoTagger::class);
     }
 
-    public function it_ignores_non_content_info(ResponseTagger $tagHandler)
+    public function it_ignores_non_content_info(ResponseTagger $tagHandler): void
     {
-        $this->tag(null);
+        $this->tag(new Location());
 
-        $tagHandler->addTags()->shouldNotHaveBeenCalled();
+        $tagHandler->addTags([])->shouldNotHaveBeenCalled();
     }
 
-    public function it_tags_with_content_and_content_type_id(ResponseTagger $tagHandler)
+    public function it_tags_with_content_and_content_type_id(ResponseTagger $tagHandler): void
     {
         $value = new ContentInfo(['id' => 123, 'contentTypeId' => 987]);
 
@@ -35,7 +37,7 @@ public function it_tags_with_content_and_content_type_id(ResponseTagger $tagHand
         $tagHandler->addTags(['c123', 'ct987'])->shouldHaveBeenCalled();
     }
 
-    public function it_tags_with_location_id_if_one_is_set(ResponseTagger $tagHandler)
+    public function it_tags_with_location_id_if_one_is_set(ResponseTagger $tagHandler): void
     {
         $value = new ContentInfo(['mainLocationId' => 456]);
 
diff --git a/spec/ResponseTagger/Value/LocationTaggerSpec.php b/spec/ResponseTagger/Value/LocationTaggerSpec.php
@@ -8,35 +8,36 @@
 use FOS\HttpCache\ResponseTagger;
 use PhpSpec\ObjectBehavior;
 use Prophecy\Argument;
+use RuntimeException;
 
 class LocationTaggerSpec extends ObjectBehavior
 {
-    public function let(ResponseTagger $tagHandler)
+    public function let(ResponseTagger $tagHandler): void
     {
         $this->beConstructedWith($tagHandler);
     }
 
-    public function it_is_initializable()
+    public function it_is_initializable(): void
     {
         $this->shouldHaveType(LocationTagger::class);
     }
 
-    public function it_ignores_non_location(ResponseTagger $tagHandler)
+    public function it_ignores_non_location(ResponseTagger $tagHandler): void
     {
-        $this->tag(null);
+        $this->tag(new ContentInfo());
 
         $tagHandler->addTags(Argument::any())->shouldNotHaveBeenCalled();
     }
 
-    public function it_tags_with_location_id_if_not_main_location(ResponseTagger $tagHandler)
+    public function it_tags_with_location_id_if_not_main_location(ResponseTagger $tagHandler): void
     {
         $value = new Location(['id' => 123, 'contentInfo' => new ContentInfo(['mainLocationId' => 321])]);
         $this->tag($value);
 
         $tagHandler->addTags(['l123'])->shouldHaveBeenCalled();
     }
 
-    public function it_tags_with_parent_location_id(ResponseTagger $tagHandler)
+    public function it_tags_with_parent_location_id(ResponseTagger $tagHandler): void
     {
         $value = new Location(['parentLocationId' => 123, 'contentInfo' => new ContentInfo()]);
 
@@ -45,7 +46,7 @@ public function it_tags_with_parent_location_id(ResponseTagger $tagHandler)
         $tagHandler->addTags(['pl123'])->shouldHaveBeenCalled();
     }
 
-    public function it_tags_with_path_items(ResponseTagger $tagHandler)
+    public function it_tags_with_path_items(ResponseTagger $tagHandler): void
     {
         $value = new Location(['pathString' => '/1/2/123', 'contentInfo' => new ContentInfo()]);
 

Original file line number	Diff line number	Diff line change
`@@ -3,30 +3,32 @@`
`3`	`3`	`namespace spec\Ibexa\HttpCache\ResponseTagger\Value;`
`4`	`4`
`5`	`5`	`use Ibexa\Contracts\Core\Repository\Values\Content\ContentInfo;`
	`6`	`+use Ibexa\Core\Repository\Values\Content\Location;`
`6`	`7`	`use Ibexa\HttpCache\ResponseTagger\Value\ContentInfoTagger;`
`7`	`8`	`use FOS\HttpCache\ResponseTagger;`
`8`	`9`	`use PhpSpec\ObjectBehavior;`
	`10`	`+use RuntimeException;`
`9`	`11`
`10`	`12`	`class ContentInfoTaggerSpec extends ObjectBehavior`
`11`	`13`	`{`
`12`		`- public function let(ResponseTagger $tagHandler)`
	`14`	`+ public function let(ResponseTagger $tagHandler): void`
`13`	`15`	`{`
`14`	`16`	`$this->beConstructedWith($tagHandler);`
`15`	`17`	`}`
`16`	`18`
`17`		`- public function it_is_initializable()`
	`19`	`+ public function it_is_initializable(): void`
`18`	`20`	`{`
`19`	`21`	`$this->shouldHaveType(ContentInfoTagger::class);`
`20`	`22`	`}`
`21`	`23`
`22`		`- public function it_ignores_non_content_info(ResponseTagger $tagHandler)`
	`24`	`+ public function it_ignores_non_content_info(ResponseTagger $tagHandler): void`
`23`	`25`	`{`
`24`		`- $this->tag(null);`
	`26`	`+ $this->tag(new Location());`
`25`	`27`
`26`		`- $tagHandler->addTags()->shouldNotHaveBeenCalled();`
	`28`	`+ $tagHandler->addTags([])->shouldNotHaveBeenCalled();`
`27`	`29`	`}`
`28`	`30`
`29`		`- public function it_tags_with_content_and_content_type_id(ResponseTagger $tagHandler)`
	`31`	`+ public function it_tags_with_content_and_content_type_id(ResponseTagger $tagHandler): void`
`30`	`32`	`{`
`31`	`33`	`$value = new ContentInfo(['id' => 123, 'contentTypeId' => 987]);`
`32`	`34`
`@@ -35,7 +37,7 @@ public function it_tags_with_content_and_content_type_id(ResponseTagger $tagHand`
`35`	`37`	`$tagHandler->addTags(['c123', 'ct987'])->shouldHaveBeenCalled();`
`36`	`38`	`}`
`37`	`39`
`38`		`- public function it_tags_with_location_id_if_one_is_set(ResponseTagger $tagHandler)`
	`40`	`+ public function it_tags_with_location_id_if_one_is_set(ResponseTagger $tagHandler): void`
`39`	`41`	`{`
`40`	`42`	`$value = new ContentInfo(['mainLocationId' => 456]);`
`41`	`43`
Original file line number	Diff line number	Diff line change
`@@ -8,35 +8,36 @@`
`8`	`8`	`use FOS\HttpCache\ResponseTagger;`
`9`	`9`	`use PhpSpec\ObjectBehavior;`
`10`	`10`	`use Prophecy\Argument;`
	`11`	`+use RuntimeException;`
`11`	`12`
`12`	`13`	`class LocationTaggerSpec extends ObjectBehavior`
`13`	`14`	`{`
`14`		`- public function let(ResponseTagger $tagHandler)`
	`15`	`+ public function let(ResponseTagger $tagHandler): void`
`15`	`16`	`{`
`16`	`17`	`$this->beConstructedWith($tagHandler);`
`17`	`18`	`}`
`18`	`19`
`19`		`- public function it_is_initializable()`
	`20`	`+ public function it_is_initializable(): void`
`20`	`21`	`{`
`21`	`22`	`$this->shouldHaveType(LocationTagger::class);`
`22`	`23`	`}`
`23`	`24`
`24`		`- public function it_ignores_non_location(ResponseTagger $tagHandler)`
	`25`	`+ public function it_ignores_non_location(ResponseTagger $tagHandler): void`
`25`	`26`	`{`
`26`		`- $this->tag(null);`
	`27`	`+ $this->tag(new ContentInfo());`
`27`	`28`
`28`	`29`	`$tagHandler->addTags(Argument::any())->shouldNotHaveBeenCalled();`
`29`	`30`	`}`
`30`	`31`
`31`		`- public function it_tags_with_location_id_if_not_main_location(ResponseTagger $tagHandler)`
	`32`	`+ public function it_tags_with_location_id_if_not_main_location(ResponseTagger $tagHandler): void`
`32`	`33`	`{`
`33`	`34`	`$value = new Location(['id' => 123, 'contentInfo' => new ContentInfo(['mainLocationId' => 321])]);`
`34`	`35`	`$this->tag($value);`
`35`	`36`
`36`	`37`	`$tagHandler->addTags(['l123'])->shouldHaveBeenCalled();`
`37`	`38`	`}`
`38`	`39`
`39`		`- public function it_tags_with_parent_location_id(ResponseTagger $tagHandler)`
	`40`	`+ public function it_tags_with_parent_location_id(ResponseTagger $tagHandler): void`
`40`	`41`	`{`
`41`	`42`	`$value = new Location(['parentLocationId' => 123, 'contentInfo' => new ContentInfo()]);`
`42`	`43`
`@@ -45,7 +46,7 @@ public function it_tags_with_parent_location_id(ResponseTagger $tagHandler)`
`45`	`46`	`$tagHandler->addTags(['pl123'])->shouldHaveBeenCalled();`
`46`	`47`	`}`
`47`	`48`
`48`		`- public function it_tags_with_path_items(ResponseTagger $tagHandler)`
	`49`	`+ public function it_tags_with_path_items(ResponseTagger $tagHandler): void`
`49`	`50`	`{`
`50`	`51`	`$value = new Location(['pathString' => '/1/2/123', 'contentInfo' => new ContentInfo()]);`
`51`	`52`