IBX-11826: Cleaned up http-cache ResponseTagger deprecations#82
Open
wiewiurdp wants to merge 3 commits into
Open
IBX-11826: Cleaned up http-cache ResponseTagger deprecations#82wiewiurdp wants to merge 3 commits into
wiewiurdp wants to merge 3 commits into
Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk and
tbialcz
and removed request for
a team
barw4
reviewed
Jun 5, 2026
…ated tests to mock `ResponseTagger` instead of specific tagger classes.
wiewiurdp
force-pushed
the
IBX-11826-Clean-up-http-cache-ResponseTagger-deprecations
branch
from
14d267e to
21f8d30
Compare
konradoboza
reviewed
Jun 8, 2026
|
konradoboza
approved these changes
Jun 8, 2026
barw4
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
#78
Description:
This PR finalizes the
ResponseTaggercleanup introduced in ibexa/http-cache#78.It adds
supports(mixed $value): boolto theResponseTaggerinterface, removesAbstractValueTagger, and simplifiesDispatcherTaggerby dropping the BC fallback for implementations withoutsupports().###Regressions:
ibexa/commerce#1841
###QA
Need some sanities.