Add isSystem property to ContentTypeGroupCreateStruct

Author: mikadamczyk

src/lib/Server/Input/Parser/ContentTypeGroupInput.php

@@ -68,6 +68,10 @@ public function parse(array $data, ParsingDispatcher $parsingDispatcher)
             $contentTypeGroupCreateStruct->creationDate = new DateTime($data['modificationDate']);
         }
 
+        if (array_key_exists('isSystem', $data)) {
+            $contentTypeGroupCreateStruct->isSystem = $this->parserTools->parseBooleanValue($data['isSystem']);
+        }
+
         // @todo mainLanguageCode, names, descriptions?
 
         if (array_key_exists('User', $data) && is_array($data['User'])) {

tests/bundle/Functional/ContentTypeTest.php

@@ -165,6 +165,8 @@ public function testLoadContentTypeGroupList()
      */
     public function testLoadContentTypeGroupListExcludesSystemByDefault(): void
     {
+        $systemIdentifier = $this->createSystemContentTypeGroup();
+
         $response = $this->sendHttpRequest(
             $this->createHttpRequest(
                 'GET',
@@ -177,14 +179,16 @@ public function testLoadContentTypeGroupListExcludesSystemByDefault(): void
 
         $identifiers = $this->getContentTypeGroupIdentifiers($response);
 
-        self::assertNotContains('system', $identifiers);
+        self::assertNotContains($systemIdentifier, $identifiers);
     }
 
     /**
      * Covers GET /content/typegroups?includeSystem=true.
      */
     public function testLoadContentTypeGroupListIncludesSystemGroups(): void
     {
+        $systemIdentifier = $this->createSystemContentTypeGroup();
+
         $response = $this->sendHttpRequest(
             $this->createHttpRequest(
                 'GET',
@@ -197,7 +201,7 @@ public function testLoadContentTypeGroupListIncludesSystemGroups(): void
 
         $identifiers = $this->getContentTypeGroupIdentifiers($response);
 
-        self::assertContains('system', $identifiers);
+        self::assertContains($systemIdentifier, $identifiers);
     }
 
     /**
@@ -213,6 +217,25 @@ public function testLoadContentTypeGroupListWithIdentifier()
         self::assertHttpResponseCodeEquals($response, 307);
     }
 
+    public function testCreateSystemContentTypeGroup(): void
+    {
+        $identifier = $this->createSystemContentTypeGroup();
+
+        $response = $this->sendHttpRequest(
+            $this->createHttpRequest(
+                'GET',
+                '/api/ibexa/v2/content/typegroups?includeSystem=true',
+                '',
+                'ContentTypeGroupList+json'
+            )
+        );
+        self::assertHttpResponseCodeEquals($response, 200);
+
+        $identifiers = $this->getContentTypeGroupIdentifiers($response);
+
+        self::assertContains($identifier, $identifiers);
+    }
+
     /**
      * @depends testUpdateContentTypeGroup
      * Covers GET /content/typegroups/<contentTypeGroupId>
@@ -734,6 +757,34 @@ static function (array $group): string {
             $groupList
         );
     }
+
+    private function createSystemContentTypeGroup(): string
+    {
+        $identifier = $this->addTestSuffix('system_group_' . uniqid());
+        $body = <<< XML
+<?xml version="1.0" encoding="UTF-8"?>
+<ContentTypeGroupInput>
+  <identifier>{$identifier}</identifier>
+  <isSystem>true</isSystem>
+</ContentTypeGroupInput>
+XML;
+
+        $request = $this->createHttpRequest(
+            'POST',
+            '/api/ibexa/v2/content/typegroups',
+            'ContentTypeGroupInput+xml',
+            'ContentTypeGroup+json',
+            $body
+        );
+
+        $response = $this->sendHttpRequest($request);
+        self::assertHttpResponseCodeEquals($response, 201);
+        self::assertHttpResponseHasHeader($response, 'Location');
+
+        $this->addCreatedElement($response->getHeader('Location')[0]);
+
+        return $identifier;
+    }
 }
 
 class_alias(ContentTypeTest::class, 'EzSystems\EzPlatformRestBundle\Tests\Functional\ContentTypeTest');

tests/lib/Server/Input/Parser/ContentTypeGroupInputTest.php

@@ -24,6 +24,7 @@ public function testParse()
                 '_href' => '/user/users/14',
             ],
             'modificationDate' => '2012-12-31T12:00:00',
+            'isSystem' => true,
         ];
 
         $contentTypeGroupInput = $this->getParser();
@@ -52,6 +53,11 @@ public function testParse()
             $result->creationDate,
             'ContentTypeGroupCreateStruct creationDate property not created correctly.'
         );
+
+        $this->assertTrue(
+            $result->isSystem,
+            'ContentTypeGroupCreateStruct isSystem property not created correctly.'
+        );
     }
 
     /**