Skip to content

Refactored Code with Typed Properties and Constructor Promotion via Rector#65

Open
tbialcz wants to merge 3 commits into
5.0from
rector-type-declarations
Open

Refactored Code with Typed Properties and Constructor Promotion via Rector#65
tbialcz wants to merge 3 commits into
5.0from
rector-type-declarations

Conversation

@tbialcz

@tbialcz tbialcz commented Feb 28, 2025

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-XXXXX

Description:

  • Applied TypedPropertyFromAssignsRector to infer and enforce typed properties.
  • Used ClassPropertyAssignToConstructorPromotionRector to simplify property assignments with constructor promotion.
  • Enabled SetList::TYPE_DECLARATION to enforce strict type declarations across the codebase.

For QA:

Documentation:

@tbialcz tbialcz requested a review from a team February 28, 2025 08:28
Comment thread src/bundle/Resources/config/services.yaml Outdated
Comment thread src/bundle/SystemInfo/Collector/ConfigurationSymfonyKernelSystemInfoCollector.php Outdated
Comment thread src/bundle/SystemInfo/Collector/IbexaSystemInfoCollector.php
Comment thread src/bundle/SystemInfo/Collector/IbexaSystemInfoCollector.php Outdated
Comment thread src/lib/Storage/AggregateMetricsProvider.php Outdated
Comment thread src/lib/Storage/AggregateMetricsProvider.php Outdated
Comment thread src/lib/Tab/SystemInfo/SystemInfoTab.php Outdated
Comment thread src/lib/Tab/SystemInfo/TabFactory.php
Comment thread tests/bundle/SystemInfo/Registry/IdentifierBasedTest.php Outdated
@sonarqubecloud

Copy link
Copy Markdown

@ibexa-yuna ibexa-yuna deleted the branch 5.0 April 29, 2026 08:25
@ibexa-yuna ibexa-yuna closed this Apr 29, 2026
@mnocon mnocon reopened this Apr 29, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@mnocon mnocon changed the base branch from main to 5.0 April 29, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants