preview items

[phanen]

• feat(previewer): parse_entry can give async preview result
• feat(ui_select): opts.preview_items

opts.preview_items: neovim/neovim#37360

[phanen]

require('fzf-lua').register_ui_select()
vim.ui.select(vim.fn.range(10), {
 preview_item = function(entry_str)
   return {
     content = { '## ' .. entry_str },
     line = 1,
     col = 1 + #'## ',
     end_col = 1 + #'## ' + #entry_str,
     filetype = 'markdown',
   }
 end,
}, print)

EDIT:

require("fzf-lua").register_ui_select()
vim.ui.select(vim.fn.range(10), {
	preview_item = function(entry_str)
		return {
			content = { { { "## " }, { entry_str, "IncSearch" } } },
			filetype = "markdown",
		}
	end,
}, print)

[ibhagwan]

Amazing @phanen, is this ready for merging or you want to play with it some more until I merge?

[phanen]

Maybe we can wait upstream to be merged (maybe they can change function signatures, to give more spec about what preview_items should return)

[ibhagwan]

7d5cc26 - great idea

[phanen]

Tested with phanen/fzf-lua-extra@6c8b373, a picker for https://github.com/alex-popov-tech/store.nvim

[ibhagwan]

Do you want this merged or still wanna wait for neovim/neovim#37360?

[phanen]

Ok, I think no problem to merge.

[ibhagwan]

Ty @phanen, sorry for the delay as traveling, hope to get to it from the airport :)

[ibhagwan]

Tysm @phanen

[neo451]

hi, great to see this proposal already landing in fzf-lua, I am the one who first raised the issue, since I want to simplify all the picker integrations in obsidian.nvim

I am basically wanting to do this:

---@param values string[]|obsidian.PickerEntry[]
---@param opts obsidian.PickerPickOpts|? Options.
M.pick = function(values, opts)
  opts = opts or {}
  local callback = opts.callback or obsidian.api.open_note
  local format_item = opts.format_item or function(entry)
    return tostring(entry.user_data)
  end

  require("fzf-lua.providers.ui_select").ui_select(values, {
    format_item = format_item,
    preview_item = function(entry)
      local buf = vim.api.nvim_create_buf(false, true)
      vim.api.nvim_buf_set_lines(buf, 0, -1, false, { "hi" })
      return {
        buf = buf,
      }
    end,
    prompt = format_prompt(opts.prompt_title),
  }, function(entry)
    if not entry then
      log.info "Aborted"
      return
    end
    callback(entry)
  end)
end

which is in compliance to the updated proposal in the upsteam issue, maybe this was merged earlier then the updated proposal, but in short the updated proposal requires only one field which is the buf, which makes a lot of sense to fill in, my current try in this shape will result in a preview window with the message unable to stat file

just a heads up, maybe we should wait till it gets merged to update accordingly.

[phanen]

Yeah, currently buf is not supported, fzf-lua never post source buffer directly to avoid messup the metainfo of a buffer like "lastused". But this can be implmented, just need to clarify who need to clear the buffer.

[neo451]

update, the upstream spec has been merged, @phanen @ibhagwan

[phanen]

fixed in #2722