Skip to content

Added Server.php hooks for creating and updating CouchDB users#12

Open
synatree wants to merge 9 commits into
ibm-watson-data-lab:masterfrom
synatree:master
Open

Added Server.php hooks for creating and updating CouchDB users#12
synatree wants to merge 9 commits into
ibm-watson-data-lab:masterfrom
synatree:master

Conversation

@synatree

Copy link
Copy Markdown

I needed to be able to create and update users on CouchDB in PHP7. Respectfully submitted.

@lornajane lornajane self-requested a review April 6, 2018 14:36

@lornajane lornajane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would LOVE to have this feature, thanks so much for the pull request! There are a couple of small things that are required though, hopefully you are still keen enough to make some changes (and if not that is fine too but please let me know in case anyone else wants to pick this up):

  • first, the build failed on coding standards. I'm sorry this project should have a CONTRIBUTING file and I will add that, but for now the info you need is here https://github.com/ibm-watson-data-lab/php-couchdb#for-developers on how to run the tests and the codesniffer check
  • the @author tag isn't usually included at a per-method level (people will see your contribution through GitHub itself)
  • this feature needs a test. Take a look at the tests directory and let me know if you need more information than "please write a test". I'm happy to help but don't want to be patronising!

@lornajane

Copy link
Copy Markdown
Contributor

Just a quick ping to check if you're OK to pick up the comments above? If not, no worries.

@synatree

Copy link
Copy Markdown
Author

Sure, I'll loop around and revisit this in a few days.

@synatree

Copy link
Copy Markdown
Author

I have not yet written any tests... but at least the spacing and formatting issues are resolved. BTW, the build passed phpcs the first time, but not --standard=PSR-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants