feat[tests]: Add extensive integration and unit tests for OpenStack VM repository and API routes

- Added pytest-based integration tests for OpenStack VM repository, including VM lifecycle, resource retrieval, and error handling.
- Implemented unit tests for repository factory to validate mock and real repository creation logic.
- Expanded error handling tests for VM API routes to improve endpoint coverage and exception handling scenarios.

Author: ibmgeniuz

.coveragerc

@@ -0,0 +1,78 @@
+[run]
+# Coverage configuration for OpenStack VM Lifecycle Management API
+
+# Source directories to measure
+source = app
+
+# Files to omit from coverage
+omit =
+    */tests/*
+    */__pycache__/*
+    */venv/*
+    */.venv/*
+    */site-packages/*
+    */__init__.py
+    */conftest.py
+    # Omit OpenStack repository from unit test coverage
+    # It's tested separately with integration tests (pytest -m integration)
+    app/repositories/openstack_vm_repository.py
+    # Omit test helpers
+    tests/openstack_helpers.py
+
+# Branch coverage (measure if/else branches)
+branch = True
+
+[report]
+# Reporting options
+
+# Show missing lines
+show_missing = True
+
+# Precision for coverage percentage
+precision = 2
+
+# Lines to exclude from coverage
+exclude_lines =
+    # Standard pragma
+    pragma: no cover
+
+    # Don't complain about missing debug code
+    def __repr__
+    def __str__
+
+    # Don't complain if tests don't hit defensive assertion code
+    raise AssertionError
+    raise NotImplementedError
+
+    # Don't complain if non-runnable code isn't run
+    if __name__ == .__main__.:
+    if TYPE_CHECKING:
+    if typing.TYPE_CHECKING:
+
+    # Don't complain about abstract methods
+    @abstractmethod
+    @abc.abstractmethod
+
+    # Don't complain about overload definitions
+    @overload
+
+    # Don't complain about ellipsis
+    \.\.\.
+
+# Note: OpenStack repository is tested with integration tests
+# Run with: USE_REAL_OPENSTACK=True pytest -m "" --cov=app
+# For unit tests only, OpenStack repository coverage is excluded below
+
+# Fail if coverage is below this threshold
+# Unit tests target: 90% (excluding OpenStack repository)
+# All tests target: 85% (including OpenStack repository)
+# fail_under = 85.0  # Commented out - manually check coverage
+
+[html]
+# HTML report configuration
+directory = htmlcov
+title = OpenStack VM API Coverage Report
+
+[xml]
+# XML report for CI/CD
+output = coverage.xml

pytest.ini

@@ -0,0 +1,36 @@
+[pytest]
+# Pytest configuration for OpenStack VM Lifecycle Management API
+
+# Test markers
+markers =
+    unit: Unit tests that use mock repository (no external dependencies)
+    integration: Integration tests that require real OpenStack connection
+    slow: Tests that take longer to execute
+
+# Default options
+# By default, run only unit tests (skip integration tests requiring OpenStack)
+addopts =
+    -v
+    --tb=short
+    --cov=app
+    --cov-report=term
+    --cov-report=html
+    -m "not integration"
+    --strict-markers
+
+# Test discovery patterns
+python_files = test_*.py
+python_classes = Test*
+python_functions = test_*
+
+# Minimum Python version
+minversion = 3.11
+
+# Test paths
+testpaths = tests
+
+# Asyncio mode
+asyncio_mode = auto
+
+# Coverage options
+# Note: Additional coverage configuration in .coveragerc

tests/conftest.py

@@ -0,0 +1,39 @@
+"""
+Test Configuration
+
+Global pytest configuration and fixtures for test suite.
+
+IMPORTANT: This module sets environment variables before any app imports.
+"""
+
+import os
+
+# Set test environment variables BEFORE any imports from app
+# This ensures settings are loaded with test configuration
+os.environ["USE_REAL_OPENSTACK"] = "False"
+os.environ["ENVIRONMENT"] = "test"
+os.environ["LOG_LEVEL"] = "WARNING"
+
+import pytest  # noqa: E402
+
+
+@pytest.fixture(scope="session", autouse=True)
+def set_test_environment():
+    """
+    Verify test environment is set correctly.
+
+    Environment variables are set at module level before imports.
+    """
+    # Verify settings
+    from app.config import settings
+
+    assert settings.use_real_openstack is False, "Tests must use mock repository"
+    assert settings.environment == "test", "Tests must run in test environment"
+
+    yield
+
+    # Cleanup after all tests
+    # Reset to default values
+    os.environ.pop("USE_REAL_OPENSTACK", None)
+    os.environ.pop("ENVIRONMENT", None)
+    os.environ.pop("LOG_LEVEL", None)

tests/openstack_helpers.py

@@ -0,0 +1,183 @@
+"""
+OpenStack Test Helpers
+
+Utility functions for OpenStack integration testing.
+"""
+
+import logging
+from typing import List, Optional
+
+import openstack
+from openstack.connection import Connection
+
+logger = logging.getLogger(__name__)
+
+
+def create_openstack_connection() -> Connection:
+    """
+    Create OpenStack connection for testing.
+
+    Returns:
+        OpenStack connection object
+
+    Raises:
+        RuntimeError: If connection fails
+    """
+    try:
+        import os
+
+        conn = openstack.connect(
+            auth_url=os.getenv("OPENSTACK_AUTH_URL", "http://192.168.2.110/identity"),
+            project_name=os.getenv("OPENSTACK_PROJECT_NAME", "demo"),
+            username=os.getenv("OPENSTACK_USERNAME", "admin"),
+            password=os.getenv("OPENSTACK_PASSWORD", "devstack"),
+            user_domain_name=os.getenv("OPENSTACK_USER_DOMAIN_NAME", "Default"),
+            project_domain_name=os.getenv("OPENSTACK_PROJECT_DOMAIN_NAME", "Default"),
+            region_name=os.getenv("OPENSTACK_REGION_NAME", "RegionOne"),
+        )
+        logger.info("OpenStack connection established for testing")
+        return conn
+    except Exception as e:
+        logger.error(f"Failed to create OpenStack connection: {e}")
+        raise RuntimeError(f"OpenStack connection failed: {e}")
+
+
+def cleanup_test_vms(
+    conn: Connection, prefix: str = "test-", max_age_seconds: Optional[int] = None
+):
+    """
+    Clean up VMs created during testing.
+
+    Args:
+        conn: OpenStack connection
+        prefix: VM name prefix to identify test VMs
+        max_age_seconds: Optional age threshold to delete older VMs
+
+    Returns:
+        Number of VMs deleted
+    """
+    try:
+        servers = list(conn.compute.servers())
+        deleted_count = 0
+
+        for server in servers:
+            if server.name.startswith(prefix):
+                try:
+                    logger.info(f"Deleting test VM: {server.name} (ID: {server.id})")
+                    conn.compute.delete_server(server, wait=True)
+                    deleted_count += 1
+                except Exception as e:
+                    logger.warning(f"Failed to delete VM {server.name}: {e}")
+
+        logger.info(f"Cleaned up {deleted_count} test VMs")
+        return deleted_count
+    except Exception as e:
+        logger.error(f"Failed to cleanup test VMs: {e}")
+        return 0
+
+
+def wait_for_server_status(
+    conn: Connection, server_id: str, expected_status: str, timeout: int = 60
+) -> bool:
+    """
+    Wait for server to reach expected status.
+
+    Args:
+        conn: OpenStack connection
+        server_id: Server ID to monitor
+        expected_status: Expected status (ACTIVE, SHUTOFF, etc.)
+        timeout: Maximum wait time in seconds
+
+    Returns:
+        True if status reached, False on timeout
+    """
+    try:
+        server = conn.compute.get_server(server_id)
+        if not server:
+            return False
+
+        server = conn.compute.wait_for_server(
+            server, status=expected_status, wait=timeout
+        )
+        return server.status == expected_status
+    except Exception as e:
+        logger.error(f"Error waiting for server status: {e}")
+        return False
+
+
+def get_available_networks(conn: Connection) -> List[str]:
+    """
+    Get list of available network names.
+
+    Args:
+        conn: OpenStack connection
+
+    Returns:
+        List of network names
+    """
+    try:
+        networks = list(conn.network.networks())
+        network_names = [net.name for net in networks]
+        logger.debug(f"Available networks: {network_names}")
+        return network_names
+    except Exception as e:
+        logger.error(f"Failed to get networks: {e}")
+        return []
+
+
+def get_available_images(conn: Connection) -> List[str]:
+    """
+    Get list of available image names.
+
+    Args:
+        conn: OpenStack connection
+
+    Returns:
+        List of image names
+    """
+    try:
+        images = list(conn.compute.images())
+        image_names = [img.name for img in images]
+        logger.debug(f"Available images: {image_names}")
+        return image_names
+    except Exception as e:
+        logger.error(f"Failed to get images: {e}")
+        return []
+
+
+def get_available_flavors(conn: Connection) -> List[str]:
+    """
+    Get list of available flavor names.
+
+    Args:
+        conn: OpenStack connection
+
+    Returns:
+        List of flavor names
+    """
+    try:
+        flavors = list(conn.compute.flavors())
+        flavor_names = [f.name for f in flavors]
+        logger.debug(f"Available flavors: {flavor_names}")
+        return flavor_names
+    except Exception as e:
+        logger.error(f"Failed to get flavors: {e}")
+        return []
+
+
+def verify_openstack_availability() -> bool:
+    """
+    Verify that OpenStack is available and accessible.
+
+    Returns:
+        True if OpenStack is available, False otherwise
+    """
+    try:
+        conn = create_openstack_connection()
+        # Try a simple operation
+        list(conn.compute.flavors(details=False, limit=1))
+        logger.info("OpenStack is available and accessible")
+        return True
+    except Exception as e:
+        logger.warning(f"OpenStack is not available: {e}")
+        return False