Merge branch 'stg101/dynamicSas' into stg101/dynamicSas

Author: ibrandes

sdk/storage/azure-storage-common/src/test/java/com/azure/storage/common/implementation/SasImplUtilsTests.java

@@ -1,6 +1,5 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
-
 package com.azure.storage.common.implementation;
 
 import org.junit.jupiter.api.BeforeEach;
@@ -12,7 +11,6 @@
 import java.util.stream.Collectors;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotEquals;;
 
 public class SasImplUtilsTests {
 
@@ -51,8 +49,9 @@ public void formatRequestHeadersForSasSigningPopulatedHeaders() {
         requestHeaders.put(Constants.HeaderConstants.CONTENT_TYPE, "contentTypeValue");
         requestHeaders.put(Constants.HeaderConstants.CLIENT_REQUEST_ID, "clientRequestId");
 
-        String expected = "x-ms-encryption-key:encryptionKeyValue\n" + "Content-Encoding:contentEncodingValue\n"
-            + "Content-Type:contentTypeValue\n" + "x-ms-client-request-id:clientRequestId\n";
+        String expected
+            = String.join("\n", "x-ms-encryption-key:encryptionKeyValue", "Content-Encoding:contentEncodingValue",
+                "Content-Type:contentTypeValue", "x-ms-client-request-id:clientRequestId");
 
         String headers = SasImplUtils.formatRequestHeadersForSasSigning(requestHeaders);
         Integer newLineCount

sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/sas/DataLakeServiceSasSignatureValues.java

@@ -484,6 +484,8 @@ public DataLakeServiceSasSignatureValues setDelegatedUserObjectId(String delegat
      * Optional. Beginning in version 2026-04-06, this value specifies Custom Request Headers to include in the SAS.
      * Any usage of the SAS must include these headers and values in the request.
      *
+     * <p>Note: This parameter is only valid for user delegation SAS. </p>
+     *
      * @return The custom request headers to be set when the SAS is used.
      */
     public Map<String, String> getRequestHeaders() {
@@ -494,6 +496,8 @@ public Map<String, String> getRequestHeaders() {
      * Optional. Beginning in version 2026-04-06, this value specifies Custom Request Headers to include in the SAS.
      * Any usage of the SAS must include these headers and values in the request.
      *
+     * <p>Note: This parameter is only valid for user delegation SAS. </p>
+     *
      * @param requestHeaders The custom request headers to be set when the SAS is used.
      * @return the updated DataLakeServiceSasSignatureValues object
      */
@@ -506,6 +510,8 @@ public DataLakeServiceSasSignatureValues setRequestHeaders(Map<String, String> r
      * Optional. Beginning in version 2026-04-06, this value specifies Custom Request Query Parameters to include in
      * the SAS. Any usage of the SAS must include these query parameters and values in the request.
      *
+     * <p>Note: This parameter is only valid for user delegation SAS. </p>
+     *
      * @return The custom query parameters to be set when the SAS is used.
      */
     public Map<String, String> getRequestQueryParameters() {
@@ -516,6 +522,8 @@ public Map<String, String> getRequestQueryParameters() {
      * Optional. Beginning in version 2026-04-06, this value specifies Custom Request Query Parameters to include in
      * the SAS. Any usage of the SAS must include these query parameters and values in the request.
      *
+     * <p>Note: This parameter is only valid for user delegation SAS. </p>
+     *
      * @param requestQueryParameters The custom query parameters to be set when the SAS is used.
      * @return the updated DataLakeServiceSasSignatureValues object
      */