refactor(migration-to-aws): Consolidate duplicate schemas into single source of truth

Implement Option 1: Consolidate all schemas in output-schema.md as the
authoritative source, removing duplicates from phase files.

Changes:
- clarify.md: Replace full clarified.json schema with reference to output-schema.md
- discover-iac.md Step 6a: Replace gcp-resource-inventory.json schema with reference
- discover-iac.md Step 6b: Replace gcp-resource-clusters.json schema with reference
- Keep critical field names in phase files for quick reference during implementation

Benefits:
- Single source of truth: output-schema.md is now the only place to update schemas
- Eliminates drift risk: No more duplicate definitions to keep in sync
- Reduces duplication: Removed 50+ lines of redundant schema examples
- Improved maintainability: Future schema changes in one place only

Previous issue: gcp-resource-inventory.json schema was inconsistent between
discover-iac.md and output-schema.md. Now resolved by consolidation.

Updates REVIEWER_FEEDBACK.md to mark issue as RESOLVED.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Author: icarthick

REVIEWER_FEEDBACK.md

@@ -171,7 +171,12 @@
 - Option 2: Create dedicated `schemas/` directory with individual schema files
 - Option 3: Use $ref references to avoid duplication
 
-**Status**: ⏳ PENDING
+**Status**: ✅ RESOLVED
+- Implemented Option 1: Consolidated all schemas in output-schema.md
+- clarify.md: Replaced full schema with reference to output-schema.md
+- discover-iac.md: Replaced gcp-resource-inventory.json and gcp-resource-clusters.json schemas with references
+- clarify-questions.md: Kept as-is (provides question definitions, not authoritative schema)
+- Single source of truth established: output-schema.md is now the only place to update schemas
 
 ---
 

plugins/migration-to-aws/skills/gcp-to-aws/references/phases/clarify.md

@@ -33,24 +33,14 @@ For Modes C/D:
 
 ## Step 4: Write Clarified Output
 
-Write `clarified.json`:
+Write `clarified.json` to `.migration/[MMDD-HHMM]/` directory.
 
-```json
-{
-  "mode": "A|B|C|D",
-  "answers": {
-    "q1_timeline": "3-6 months",
-    "q2_primary_concern": "cost",
-    "q3_team_experience": "moderate",
-    "q4_traffic_profile": "predictable",
-    "q5_database_requirements": "structured",
-    "q6_cost_sensitivity": "high",
-    "q7_multi_cloud": "no",
-    "q8_compliance": "none"
-  },
-  "timestamp": "2026-02-26T14:30:00Z"
-}
-```
+**Schema:** See `references/shared/output-schema.md` → `clarified.json (Phase 2 output)` section for complete schema and field documentation.
+
+**Key fields:**
+- `mode`: "A", "B", "C", or "D" (answering mode selected in Step 2)
+- `answers`: Object with keys q1_timeline through q8_compliance
+- `timestamp`: ISO 8601 timestamp
 
 ## Step 5: Update Phase Status
 

plugins/migration-to-aws/skills/gcp-to-aws/references/phases/discover/discover-iac.md

@@ -70,103 +70,30 @@ Extracts and clusters GCP resources from Terraform files. Produces final invento
 ### 6a: Write gcp-resource-inventory.json
 
 1. Create file: `.migration/[MMDD-HHMM]/gcp-resource-inventory.json`
-2. Write with exact schema (see below):
-
-   ```json
-   {
-     "timestamp": "2026-02-26T14:30:00Z",
-     "metadata": {
-       "total_resources": 50,
-       "primary_resources": 12,
-       "secondary_resources": 38,
-       "total_clusters": 6,
-       "terraform_available": true
-     },
-     "resources": [
-       {
-         "address": "google_cloud_run_service.api",
-         "type": "google_cloud_run_service",
-         "classification": "PRIMARY",
-         "secondary_role": null,
-         "cluster_id": "compute_cloudrun_001",
-         "config": {
-           "region": "us-central1",
-           "name": "api"
-         },
-         "dependencies": ["google_sql_database_instance.main"],
-         "depth": 2,
-         "serves": []
-       },
-       {
-         "address": "google_service_account.app",
-         "type": "google_service_account",
-         "classification": "SECONDARY",
-         "secondary_role": "identity",
-         "cluster_id": "compute_cloudrun_001",
-         "config": {},
-         "dependencies": [],
-         "depth": 1,
-         "serves": ["google_cloud_run_service.api"]
-       }
-     ]
-   }
-   ```
+2. Write with exact schema per `references/shared/output-schema.md` → `gcp-resource-inventory.json (Phase 1 output)` section
 
 **CRITICAL field names (use EXACTLY these):**
 
 - `address` (resource Terraform address)
 - `type` (resource Terraform type)
 - `classification` (PRIMARY or SECONDARY)
-- `secondary_role` (for secondaries only)
+- `secondary_role` (for secondaries only; one of: identity, access_control, network_path, configuration, encryption, orchestration)
 - `cluster_id` (assigned cluster)
-- `depth` (topological depth)
-- `serves` (for secondaries only)
+- `depth` (topological depth, integer ≥ 0)
+- `serves` (for secondaries only; list of resources this secondary supports)
 
 ### 6b: Write gcp-resource-clusters.json
 
 1. Create file: `.migration/[MMDD-HHMM]/gcp-resource-clusters.json`
-2. Write with exact schema:
-
-   ```json
-   {
-     "timestamp": "2026-02-26T14:30:00Z",
-     "metadata": {
-       "total_clusters": 6
-     },
-     "clusters": [
-       {
-         "cluster_id": "compute_cloudrun_001",
-         "name": "Cloud Run Services",
-         "type": "compute",
-         "description": "Primary: cloud_run_service, Secondary: service_account, iam_member",
-         "gcp_region": "us-central1",
-         "primary_resources": ["google_cloud_run_service.api", "google_cloud_run_service.worker"],
-         "secondary_resources": [
-           "google_service_account.app",
-           "google_cloud_run_service_iam_member.*"
-         ],
-         "network": "network_vpc_001",
-         "creation_order_depth": 2,
-         "must_migrate_together": true,
-         "dependencies": ["database_sql_001"],
-         "edges": [
-           {
-             "from": "google_cloud_run_service.api",
-             "to": "google_sql_database_instance.main",
-             "relationship_type": "data_dependency"
-           }
-         ]
-       }
-     ]
-   }
-   ```
+2. Write with exact schema per `references/shared/output-schema.md` → `gcp-resource-clusters.json (Phase 1 output)` section
 
 **CRITICAL field names (use EXACTLY these):**
 
 - `cluster_id` (matches resources' cluster_id)
 - `primary_resources` (array of addresses)
 - `secondary_resources` (array of addresses)
 - `creation_order_depth` (matches resource depths)
+- `gcp_region` (GCP region for this cluster)
 - `edges` (array of {from, to, relationship_type})
 
 ### 6c: Validate Both Files Exist