Skip to content

Commit 924be14

Browse files
icarthickclaude
andcommitted
fix(migration-to-aws): Fix depth pseudocode direction and README scope claims
1. Fix depth-calculation.md pseudocode (Critical Issue #1) - Problem: Pseudocode used depends_on[R] (wrong direction) - Prose said 'resources that depend on R' but code did the opposite - Fix: Build dependents_of reverse adjacency structure - Now correctly processes resources that depend on R - Dependent resources get higher depths (deploy later) 2. Fix README.md v1.0 vs v1.1+ scope (Critical Issue awslabs#2) - Problem: Claimed 'IaC generation' as v1.0 feature - But SKILL.md line 110 says 'v1.0 is design/estimate only' - App code, billing data, IaC deferred to v1.1+ - Fix: Update plugin description to 'execution planning' - Update workflow steps: Discover, Clarify, Design, Estimate, Execute - Execute phase now correctly described as 'Plan migration timeline' Build: All linters, manifests, security scans pass ✓ Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
1 parent ca5dd5d commit 924be14

2 files changed

Lines changed: 16 additions & 9 deletions

File tree

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ To maximize the benefits of plugin-assisted development while maintaining securi
2626

2727
## Plugins
2828

29-
| Plugin | Description | Status |
30-
| --------------------------- | ------------------------------------------------------------------------------------------------------------------ | --------- |
31-
| **deploy-on-aws** | Deploy applications to AWS with architecture recommendations, cost estimates, and IaC deployment | Available |
32-
| **amazon-location-service** | Add maps, geocoding, routing, places search, and geospatial features to applications with Amazon Location Service | Available |
33-
| **migration-to-aws** | Migrate GCP infrastructure to AWS with resource discovery, architecture mapping, cost analysis, and IaC generation | Available |
29+
| Plugin | Description | Status |
30+
| --------------------------- | ---------------------------------------------------------------------------------------------------------------------- | --------- |
31+
| **deploy-on-aws** | Deploy applications to AWS with architecture recommendations, cost estimates, and IaC deployment | Available |
32+
| **amazon-location-service** | Add maps, geocoding, routing, places search, and geospatial features to applications with Amazon Location Service | Available |
33+
| **migration-to-aws** | Migrate GCP infrastructure to AWS with resource discovery, architecture mapping, cost analysis, and execution planning | Available |
3434

3535
## Installation
3636

@@ -119,11 +119,11 @@ Helps you systematically migrate GCP infrastructure to AWS through resource disc
119119

120120
### Workflow
121121

122-
1. **Discover** - Scan GCP infrastructure (Terraform, billing, app code) and extract resources
122+
1. **Discover** - Scan Terraform files for GCP resources and extract infrastructure
123123
2. **Clarify** - Understand compute workloads and architecture patterns
124124
3. **Design** - Map GCP services to AWS equivalents with rationale
125125
4. **Estimate** - Calculate monthly AWS costs and compare to GCP
126-
5. **Execute** - Generate working Infrastructure-as-Code (CDK/CloudFormation)
126+
5. **Execute** - Plan migration timeline and identify deployment risks
127127

128128
### Agent Skill Triggers
129129

plugins/migration-to-aws/skills/gcp-to-aws/references/clustering/terraform/depth-calculation.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,20 +68,27 @@ function calculateDepth(resources) {
6868
// Build graph
6969
in_degree = {}
7070
depends_on = {}
71+
dependents_of = {} // Reverse adjacency: resource → resources that depend on it
7172
for each resource R:
7273
in_degree[R] = count incoming edges
7374
depends_on[R] = R.dependencies[]
75+
dependents_of[R] = []
76+
77+
// Populate dependents_of (reverse edges)
78+
for each resource R:
79+
for each D in R.dependencies[]:
80+
dependents_of[D].append(R)
7481
7582
// Initialize depth 0
7683
depth = {}
7784
queue = [R for R in resources if in_degree[R] == 0]
7885
for each R in queue:
7986
depth[R] = 0
8087
81-
// Process
88+
// Process queue (longest path variant)
8289
while queue not empty:
8390
R = queue.dequeue()
84-
for each D in depends_on[R]:
91+
for each D in dependents_of[R]: // Iterate resources that depend on R
8592
depth[D] = max(depth[D], depth[R] + 1)
8693
in_degree[D] -= 1
8794
if in_degree[D] == 0:

0 commit comments

Comments
 (0)