Skip to content

Commit c32df72

Browse files
icarthickclaude
andcommitted
fix(migration-to-aws): Resolve 3 remaining reviewer issues
1. Fix depth calculation algorithm direction (depth-calculation.md) - Previous: Algorithm processed R's dependencies (backwards) - Fixed: Now correctly processes resources that depend on R - Result: Dependent resources get higher depths (deploy later) 2. Resolve google_compute_network classification contradiction - Previous: Listed as PRIMARY in classification-rules.md - But: Shown as SECONDARY in output-schema.md example - And: Clustering Rule 1 treats networks specially - Fixed: Move google_compute_network to SECONDARY / network_path - Reason: Networks are infrastructure, not workloads 3. Fix remaining cluster ID format inconsistency (design.md) - Previous: Still used old format "web-app-us-central1" - Fixed: Updated to new format "compute_instance_us-central1_001" - Aligns with: clustering-algorithm.md Rule 6 specification All reviewer feedback now fully addressed. Build passes all checks. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
1 parent 3ff0cac commit c32df72

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

plugins/migration-to-aws/skills/gcp-to-aws/references/clustering/terraform/classification-rules.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ These resource types are always PRIMARY:
1717
- `google_redis_instance` — In-memory cache
1818
- `google_pubsub_topic` — Message queue
1919
- `google_dns_managed_zone` — DNS zone
20-
- `google_compute_network` — Virtual network
2120
- `google_monitoring_alert_policy` — Alert rule
2221
- `google_project_service` — API service enablement
2322
- `module.*` — Terraform module (treated as primary container)
@@ -39,6 +38,7 @@ Match resource type against secondary classification table. Each match assigns a
3938

4039
### Network Path (`network_path`)
4140

41+
- `google_compute_network` — Virtual network (VPC)
4242
- `google_vpc_access_connector` — VPC connector for serverless
4343
- `google_compute_subnetwork` — Subnet
4444
- `google_compute_firewall` — Firewall rule

plugins/migration-to-aws/skills/gcp-to-aws/references/clustering/terraform/depth-calculation.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,13 @@ Assign: `depth[resource] = 0` for all queued resources.
3939
While queue not empty:
4040

4141
1. **Dequeue** resource R
42-
2. **For each** resource D in R's `dependencies[]`:
42+
2. **For each** resource D that depends on R (traverse reverse edges):
4343
- Update: `depth[D] = max(depth[D], depth[R] + 1)`
4444
- Decrement: `in_degree[D] -= 1`
4545
- **If** `in_degree[D]` becomes 0: **Enqueue** D
4646

47+
**Note:** "Resources that depend on R" means all resources X where X's `dependencies[]` contains R. This correctly assigns higher depths to dependent resources (which must deploy later).
48+
4749
### Step 4: Cycle Detection
4850

4951
If queue empties but unassigned resources remain:

plugins/migration-to-aws/skills/gcp-to-aws/references/phases/design.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ For each SECONDARY resource:
6363
{
6464
"clusters": [
6565
{
66-
"cluster_id": "web-app-us-central1",
66+
"cluster_id": "compute_instance_us-central1_001",
6767
"gcp_region": "us-central1",
6868
"aws_region": "us-east-1",
6969
"resources": [

0 commit comments

Comments
 (0)