Commit c32df72
fix(migration-to-aws): Resolve 3 remaining reviewer issues
1. Fix depth calculation algorithm direction (depth-calculation.md)
- Previous: Algorithm processed R's dependencies (backwards)
- Fixed: Now correctly processes resources that depend on R
- Result: Dependent resources get higher depths (deploy later)
2. Resolve google_compute_network classification contradiction
- Previous: Listed as PRIMARY in classification-rules.md
- But: Shown as SECONDARY in output-schema.md example
- And: Clustering Rule 1 treats networks specially
- Fixed: Move google_compute_network to SECONDARY / network_path
- Reason: Networks are infrastructure, not workloads
3. Fix remaining cluster ID format inconsistency (design.md)
- Previous: Still used old format "web-app-us-central1"
- Fixed: Updated to new format "compute_instance_us-central1_001"
- Aligns with: clustering-algorithm.md Rule 6 specification
All reviewer feedback now fully addressed. Build passes all checks.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>1 parent 3ff0cac commit c32df72
3 files changed
Lines changed: 5 additions & 3 deletions
File tree
- plugins/migration-to-aws/skills/gcp-to-aws/references
- clustering/terraform
- phases
plugins/migration-to-aws/skills/gcp-to-aws/references/clustering/terraform/classification-rules.md
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
0 commit comments