Merge pull request #24 from icerockdev/develop

Release 0.3.3

Author: Alex009

buildSrc/src/main/kotlin/Deps.kt

@@ -10,12 +10,12 @@ object Deps {
     private const val androidLifecycleVersion = "2.1.0"
     private const val androidCoreTestingVersion = "2.1.0"
 
-    private const val detektVersion = "1.7.4"
+    private const val detektVersion = "1.15.0"
 
     private const val coroutinesVersion = "1.4.2"
     private const val mokoMvvmVersion = "0.9.2"
     private const val mokoResourcesVersion = "0.15.1"
-    const val mokoErrorsVersion = "0.3.2"
+    const val mokoErrorsVersion = "0.3.3"
 
     object Android {
         const val compileSdk = 28

errors/src/iosMain/kotlin/dev/icerock/moko/errors/handler/ExceptionHandlerBinder.kt

@@ -22,18 +22,23 @@ actual class ExceptionHandlerBinderImpl<T : Any> actual constructor(
     private var eventsListener: ErrorEventListener<T>? = null
 
     override fun bind(viewController: UIViewController) {
-        eventsListener = createEventsListener(viewController)
+        eventsListener = Listener(
+            viewController = viewController,
+            errorPresenter = errorPresenter
+        )
         eventsDispatcher.listener = eventsListener
     }
 
-    private fun createEventsListener(viewController: UIViewController) =
-        object : ErrorEventListener<T> {
-            val viewControllerRef = WeakReference(viewController)
+    private class Listener<T : Any>(
+        viewController: UIViewController,
+        private val errorPresenter: ErrorPresenter<T>
+    ) : ErrorEventListener<T> {
+        private val viewControllerRef = WeakReference(viewController)
 
-            override fun showError(throwable: Throwable, data: T) {
-                viewControllerRef.get()?.let {
-                    errorPresenter.show(throwable, it, data)
-                }
-            }
+        override fun showError(throwable: Throwable, data: T) {
+            val viewController = viewControllerRef.get() ?: return
+
+            errorPresenter.show(throwable, viewController, data)
         }
+    }
 }