Open
Conversation
Boobl1k
commented
Mar 30, 2026
| } | ||
| } | ||
|
|
||
| private fun hasKonformValidatedAnnotation(method: Method, index: Int): Boolean { |
Author
There was a problem hiding this comment.
check out spring annotation utils
Author
There was a problem hiding this comment.
org.springframework.core.annotation.AnnotationUtils
org.springframework.core.annotation.AnnotatedElementUtils
Author
There was a problem hiding this comment.
these util classes does not provide functionality to search annotations for parameters in hierarchy. As I understand, they have it for methods and classes only, not for method parameters. So I would keep current implementation
Boobl1k
commented
Mar 30, 2026
|
|
||
| @Component | ||
| @ConditionalOnProperty("konform.use-localization", havingValue = "true") | ||
| class ConformValidationMessageFormatterWithLocalization( |
Boobl1k
commented
Mar 30, 2026
|
|
||
| @Component | ||
| @ConditionalOnProperty("konform.use-localization", havingValue = "false", matchIfMissing = true) | ||
| class ConformValidationMessageFormatterDefault : ConformValidationMessageFormatter { |
Author
There was a problem hiding this comment.
use conditionalOnMissingBean here
Boobl1k
force-pushed
the
task/WD-307
branch
2 times, most recently
from
f55cc6e to
ffa140d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.