fix(runtime): return pruned helper routes before parsing

Author: masterkain

lib/codex_pooler_web/plugs/runtime_ingress.ex

@@ -24,6 +24,22 @@ defmodule CodexPoolerWeb.Plugs.RuntimeIngress do
 
   @json_error_type "invalid_request_error"
 
+  @pruned_runtime_helper_routes [
+    {"GET", ["backend-api", "codex", "agent-identities", "jwks"]},
+    {"GET", ["backend-api", "wham", "agent-identities", "jwks"]},
+    {"POST", ["api", "codex", "rate-limit-reset-credits", "consume"]},
+    {"POST", ["wham", "rate-limit-reset-credits", "consume"]},
+    {"POST", ["backend-api", "wham", "rate-limit-reset-credits", "consume"]},
+    {"POST", ["backend-api", "codex", "thread", "goal", "get"]},
+    {"POST", ["backend-api", "codex", "thread", "goal", "set"]},
+    {"POST", ["backend-api", "codex", "thread", "goal", "clear"]},
+    {"POST", ["backend-api", "codex", "analytics-events", "events"]},
+    {"POST", ["backend-api", "codex", "memories", "trace_summarize"]},
+    {"POST", ["backend-api", "codex", "alpha", "search"]},
+    {"POST", ["backend-api", "codex", "realtime", "calls"]},
+    {"POST", ["backend-api", "codex", "safety", "arc"]}
+  ]
+
   def init(opts), do: opts
 
   def call(conn, _opts) do
@@ -36,6 +52,9 @@ defmodule CodexPoolerWeb.Plugs.RuntimeIngress do
         |> admit_mcp_request()
         |> prepare_mcp_body(settings)
 
+      pruned_runtime_helper_request?(conn) ->
+        send_pruned_runtime_helper_absent(conn)
+
       runtime_path?(conn.path_info) ->
         settings = OperationalSettings.current()
 
@@ -379,6 +398,11 @@ defmodule CodexPoolerWeb.Plugs.RuntimeIngress do
 
   def protected_backend_raw_request?(_conn), do: false
 
+  @spec pruned_runtime_helper_request?(Plug.Conn.t()) :: boolean()
+  defp pruned_runtime_helper_request?(%Plug.Conn{method: method, path_info: path_info}) do
+    {method, path_info} in @pruned_runtime_helper_routes
+  end
+
   defp decode_or_send_compressed_body(conn, settings) do
     case CompressedBody.decode(conn, settings) do
       {:ok, conn} -> conn
@@ -387,6 +411,13 @@ defmodule CodexPoolerWeb.Plugs.RuntimeIngress do
     end
   end
 
+  defp send_pruned_runtime_helper_absent(conn) do
+    conn
+    |> put_resp_content_type("text/html")
+    |> send_resp(404, "Not Found")
+    |> halt()
+  end
+
   defp runtime_path?(path_info) do
     Enum.any?(@runtime_prefixes, &List.starts_with?(path_info, &1))
   end

test/codex_pooler_web/plugs/runtime_ingress_test.exs

@@ -3,6 +3,7 @@ defmodule CodexPoolerWeb.Plugs.RuntimeIngressTest do
 
   import CodexPooler.PoolerFixtures
 
+  alias CodexPooler.Accounting.Request
   alias CodexPooler.Catalog.PricingSnapshot
   alias CodexPooler.FakeUpstream
   alias CodexPooler.Gateway.OperationalSettings
@@ -304,6 +305,34 @@ defmodule CodexPoolerWeb.Plugs.RuntimeIngressTest do
         assert response(conn, 404) =~ "Not Found"
       end
     end
+
+    test "malformed pruned thread goal set returns absent before parsing or side effects", %{
+      conn: conn
+    } do
+      setup_runtime_ingress(%OperationalSettings{})
+
+      conn =
+        conn
+        |> put_req_header("content-type", "application/json")
+        |> post("/backend-api/codex/thread/goal/set", ~s({"goal":))
+
+      assert response(conn, 404) =~ "Not Found"
+      assert Repo.aggregate(Request, :count) == 0
+    end
+
+    test "malformed pruned reset-credit consume returns absent before parsing or side effects", %{
+      conn: conn
+    } do
+      setup_runtime_ingress(%OperationalSettings{})
+
+      conn =
+        conn
+        |> put_req_header("content-type", "application/json")
+        |> post("/api/codex/rate-limit-reset-credits/consume", ~s({"redeem_request_id":))
+
+      assert response(conn, 404) =~ "Not Found"
+      assert Repo.aggregate(Request, :count) == 0
+    end
   end
 
   describe "compressed runtime API requests" do