chore: satisfy code-health quality gates

Author: masterkain

lib/codex_pooler/alerts/webhook_delivery.ex

@@ -90,16 +90,17 @@ defmodule CodexPooler.Alerts.WebhookDelivery do
   def retry_delay_seconds(attempt_number), do: Map.get(@retry_delays_seconds, attempt_number, 0)
 
   defp deliver_after_pending_attempt(attempt, incident, channel, endpoint_url, timestamp) do
-    with {:ok, signing_secret} <- recover_signing_secret(channel) do
-      deliver_pending_attempt(
-        attempt,
-        incident,
-        channel,
-        endpoint_url,
-        signing_secret,
-        timestamp
-      )
-    else
+    case recover_signing_secret(channel) do
+      {:ok, signing_secret} ->
+        deliver_pending_attempt(
+          attempt,
+          incident,
+          channel,
+          endpoint_url,
+          signing_secret,
+          timestamp
+        )
+
       {:failure, code, message} ->
         finalize_failed_attempt(attempt, code, message, false, nil, timestamp)
     end

lib/codex_pooler_web/live/admin/pages/upstream_cockpit_live.ex

@@ -357,11 +357,6 @@ defmodule CodexPoolerWeb.Admin.UpstreamCockpitLive do
 
   defp action_label(:replace_auth_json), do: "Replace auth.json"
   defp action_label(:oauth_relink), do: "OAuth relink"
-  defp action_label(:refresh_token), do: "Refresh token"
-  defp action_label(:redeem_saved_reset), do: "Redeem saved reset"
-
-  defp action_label(action_key),
-    do: action_key |> to_string() |> String.replace("_", " ") |> String.capitalize()
 
   defp selected_pool(scope, pool_id) when is_binary(pool_id) do
     scope

lib/codex_pooler_web/live/admin/pages/upstream_cockpit_live/account_lifecycle_workflow.ex

@@ -243,10 +243,7 @@ defmodule CodexPoolerWeb.Admin.UpstreamCockpitLive.AccountLifecycleWorkflow do
     put_flash(socket, :error, "#{action_label(action_key)} is not available: #{reason}")
   end
 
-  defp action_label(:replace_auth_json), do: "Replace auth.json"
-  defp action_label(:oauth_relink), do: "OAuth relink"
   defp action_label(:refresh_token), do: "Refresh token"
-  defp action_label(:redeem_saved_reset), do: "Redeem saved reset"
 
   defp action_label(action_key),
     do: action_key |> to_string() |> String.replace("_", " ") |> String.capitalize()

lib/codex_pooler_web/live/admin/pages/upstream_cockpit_live/saved_reset_workflow.ex

@@ -130,17 +130,9 @@ defmodule CodexPoolerWeb.Admin.UpstreamCockpitLive.SavedResetWorkflow do
   defp put_unavailable_action_error(socket, action_key) do
     action = Map.fetch!(socket.assigns.cockpit.actions, action_key)
     reason = action.reason || "action is unavailable"
-    put_flash(socket, :error, "#{action_label(action_key)} is not available: #{reason}")
+    put_flash(socket, :error, "Redeem saved reset is not available: #{reason}")
   end
 
-  defp action_label(:replace_auth_json), do: "Replace auth.json"
-  defp action_label(:oauth_relink), do: "OAuth relink"
-  defp action_label(:refresh_token), do: "Refresh token"
-  defp action_label(:redeem_saved_reset), do: "Redeem saved reset"
-
-  defp action_label(action_key),
-    do: action_key |> to_string() |> String.replace("_", " ") |> String.capitalize()
-
   defp error_message(%Ecto.Changeset{} = changeset) do
     changeset
     |> Ecto.Changeset.traverse_errors(fn {message, _opts} -> message end)