Use nameof

GrahamTheCoder · GrahamTheCoder · commit 02af5b190ab5 · 2019-12-15T21:38:29.000Z
diff --git a/ICSharpCode.CodeConverter/CSharp/ExpressionNodeVisitor.cs b/ICSharpCode.CodeConverter/CSharp/ExpressionNodeVisitor.cs
@@ -665,7 +665,7 @@ public override async Task<CSharpSyntaxNode> VisitInvocationExpression(VBasic.Sy
             var expressionSymbol = _semanticModel.GetSymbolInfo(node.Expression).ExtractBestMatch();
             var expressionReturnType = expressionSymbol?.GetReturnType() ?? _semanticModel.GetTypeInfo(node.Expression).Type;
             var operation = _semanticModel.GetOperation(node);
-            if (expressionSymbol?.ContainingNamespace.MetadataName == "VisualBasic" && await SubstituteVisualBasicMethodOrNull(node) is CSharpSyntaxNode csEquivalent) {
+            if (expressionSymbol?.ContainingNamespace.MetadataName == nameof(Microsoft.VisualBasic) && await SubstituteVisualBasicMethodOrNull(node) is CSharpSyntaxNode csEquivalent) {
                 return csEquivalent;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -665,7 +665,7 @@ public override async Task<CSharpSyntaxNode> VisitInvocationExpression(VBasic.Sy`
`665`	`665`	`var expressionSymbol = _semanticModel.GetSymbolInfo(node.Expression).ExtractBestMatch();`
`666`	`666`	`var expressionReturnType = expressionSymbol?.GetReturnType() ?? _semanticModel.GetTypeInfo(node.Expression).Type;`
`667`	`667`	`var operation = _semanticModel.GetOperation(node);`
`668`		`- if (expressionSymbol?.ContainingNamespace.MetadataName == "VisualBasic" && await SubstituteVisualBasicMethodOrNull(node) is CSharpSyntaxNode csEquivalent) {`
	`668`	`+ if (expressionSymbol?.ContainingNamespace.MetadataName == nameof(Microsoft.VisualBasic) && await SubstituteVisualBasicMethodOrNull(node) is CSharpSyntaxNode csEquivalent) {`
`669`	`669`	`return csEquivalent;`
`670`	`670`	`}`
`671`	`671`