Merge pull request #275 from mrmonday/269-remove-base-finalize

Ensure base.Finalize() is removed

Author: GrahamTheCoder

ICSharpCode.CodeConverter/CSharp/MethodBodyVisitor.cs

@@ -105,6 +105,12 @@ private static SyntaxKind ConvertAddRemoveHandlerToCSharpSyntaxKind(VBSyntax.Add
 
             public override SyntaxList<StatementSyntax> VisitExpressionStatement(VBSyntax.ExpressionStatementSyntax node)
             {
+                if (node.Expression is VBSyntax.InvocationExpressionSyntax invoke &&
+                    invoke.Expression is VBSyntax.MemberAccessExpressionSyntax expr &&
+                    expr.Expression is VBSyntax.MyBaseExpressionSyntax &&
+                    expr.Name.Identifier.ValueText.Equals("Finalize", StringComparison.OrdinalIgnoreCase)) {
+                    return new SyntaxList<StatementSyntax>();
+                }
                 return SingleStatement((ExpressionSyntax)node.Expression.Accept(_nodesVisitor));
             }
 

Tests/CSharp/ExpressionTests.cs

@@ -1090,5 +1090,20 @@ public string StringInter(string t, DateTime dt)
     }
 }");
         }
+
+        [Fact]
+        public void BaseFinalizeRemoved()
+        {
+            TestConversionVisualBasicToCSharpWithoutComments(@"Public Class Class1
+    Protected Overrides Sub Finalize()
+        MyBase.Finalize()
+    End Sub
+End Class", @"public class Class1
+{
+    ~Class1()
+    {
+    }
+}");
+        }
     }
 }