Accessors should always exist on VB auto-properties - fixes #237

Because of the backing field which can always be used

Author: GrahamTheCoder

ICSharpCode.CodeConverter/CSharp/NodesVisitor.cs

@@ -7,6 +7,7 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
+using Microsoft.CodeAnalysis.FindSymbols;
 using SyntaxFactory = Microsoft.CodeAnalysis.CSharp.SyntaxFactory;
 using VBSyntax = Microsoft.CodeAnalysis.VisualBasic.Syntax;
 using VBasic = Microsoft.CodeAnalysis.VisualBasic;
@@ -449,15 +450,17 @@ public override CSharpSyntaxNode VisitPropertyStatement(VBSyntax.PropertyStateme
 
                 AccessorListSyntax accessors = null;
                 if (!hasBody) {
-                    var accessorList = new List<AccessorDeclarationSyntax>();
-
-                    if (!isWriteOnly) {
-                        accessorList.Add(SyntaxFactory.AccessorDeclaration(SyntaxKind.GetAccessorDeclaration).WithSemicolonToken(SemicolonToken));
+                    var getAccessor = SyntaxFactory.AccessorDeclaration(SyntaxKind.GetAccessorDeclaration).WithSemicolonToken(SemicolonToken);
+                    var setAccessor = SyntaxFactory.AccessorDeclaration(SyntaxKind.SetAccessorDeclaration).WithSemicolonToken(SemicolonToken);
+                    if (isWriteOnly) {
+                        getAccessor = getAccessor.AddModifiers(SyntaxFactory.Token(SyntaxKind.PrivateKeyword));
                     }
-                    if (!isReadonly) {
-                        accessorList.Add(SyntaxFactory.AccessorDeclaration(SyntaxKind.SetAccessorDeclaration).WithSemicolonToken(SemicolonToken));
+                    if (isReadonly) {
+                        setAccessor = setAccessor.AddModifiers(SyntaxFactory.Token(SyntaxKind.PrivateKeyword));
                     }
-                    accessors = SyntaxFactory.AccessorList(SyntaxFactory.List(accessorList));
+                    // In VB, there's a backing field which can always be read and written to even on ReadOnly/WriteOnly properties.
+                    // Our conversion will rewrite usages of that field to use the property accessors which therefore must exist and be private at minimum.
+                    accessors = SyntaxFactory.AccessorList(SyntaxFactory.List(new[] {getAccessor, setAccessor}));
                 } else {
                     accessors = SyntaxFactory.AccessorList(
                         SyntaxFactory.List(

Tests/CSharp/ExpressionTests.cs

@@ -594,7 +594,7 @@ class TestClass3
 {
     private class Rec
     {
-        public Rec Prop { get; } = new Rec();
+        public Rec Prop { get; private set; } = new Rec();
     }
     private Rec TestMethod(string str)
     {

Tests/CSharp/MemberTests.cs

@@ -699,7 +699,7 @@ Private ReadOnly Property First As New List(Of String)
 
 class TestClass
 {
-    private List<string> First { get; } = new List<string>();
+    private List<string> First { get; private set; } = new List<string>();
     private int Second { get; set; } = 0;
 }");
         }
@@ -1258,7 +1258,28 @@ public void TestWriteOnlyProperties()
     WriteOnly Property Items As Integer()
 End Interface", @"interface TestInterface
 {
-    int[] Items { set; }
+    int[] Items { private get; set; }
+}");
+        }
+
+        [Fact]
+        public void TestImplicitPrivateSetter()
+        {
+            TestConversionVisualBasicToCSharp(
+@"Public Class SomeClass
+    Public ReadOnly Property SomeValue As Integer
+
+    Public Sub SetValue(value1 As Integer, value2 As Integer)
+        _SomeValue = value1 + value2
+    End Sub
+End Class", @"public class SomeClass
+{
+    public int SomeValue { get; private set; }
+
+    public void SetValue(int value1, int value2)
+    {
+        SomeValue = value1 + value2;
+    }
 }");
         }