Skip to content

Commit 73137da

Browse files
Finish consolidating
1 parent 012a2be commit 73137da

File tree

4 files changed

+4
-14
lines changed

4 files changed

+4
-14
lines changed

.github/workflows/dotnet.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
uses: actions/upload-artifact@v4
6666
with:
6767
name: ICSharpCode.CodeConverter.CodeConv.${{ env.BuildVersion }}.nupkg
68-
path: CommandLine/CodeConv/bin/${{ env.BuildTarget }}/ICSharpCode.CodeConverter.CodeConv.*.nupkg
68+
path: CodeConv/bin/${{ env.BuildTarget }}/ICSharpCode.CodeConverter.CodeConv.*.nupkg
6969
- name: Upload Web
7070
uses: actions/upload-artifact@v4
7171
with:

.openhands/microagents/repo.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ This repository contains a code conversion tool that translates between C# and V
1414

1515
## Repository Structure
1616
- `CodeConverter/`: Core conversion logic
17-
- `CommandLine/`: CLI tools for conversion
17+
- `CodeConv/`: CLI tool for conversion
1818
- `Tests/`: Comprehensive test suite
1919
- `Web/`: Web interface components
2020
- `Vsix/`: Visual Studio extension

CodeConv/README.md

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,4 @@ Remarks:
4141

4242
## Design
4343

44-
The tool can run in both netcore and netframework because:
45-
- The conversion needs to be able run in a dot net core process so it works cross platform
46-
- So linux users can convert dot net core projects
47-
- The conversion needs to be able to run in a net framework process because:
48-
- Dot net core msbuild can't load framework projects (i.e. 95% of the world's VB and C#)
49-
- Dot net core processes can't load net framework msbuild ([not planned to change](https://github.com/icsharpcode/CodeConverter/blob/master/CommandLine/CodeConv.Shared/CodeConvProgram.cs#L73-L81))
50-
51-
## Future
52-
53-
The package is about 27MB. The size is made up by the Roslyn dependencies. It includes most of Roslyn, but not MSBuild (which must be installed on the machine). In future we could get Roslyn from the installation too like the VS extension does. It just needs careful management of versions. The dot net framework version can match the vs extension dependency versions. The dot net core one can depend on later versions.
44+
The tool doesn't support netframework because dot net core's build process can't build net framework projects. The old version of this tool loaded a separate net framework command line referencing msbuild, but that was hard work to maintain. If there's high demand, it could be resurrected, but it's probably best for people to upgrade to a recent version of dot net first anyway.

Linux.slnf

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
"path": "CodeConverter.sln",
44
"projects": [
55
"CodeConverter/CodeConverter.csproj",
6-
"CommandLine/CodeConv/CodeConv.csproj",
7-
"CommandLine/CodeConv.NetFramework/CodeConv.NetFramework.csproj",
6+
"CodeConv/CodeConv.csproj",
87
"Tests/Tests.csproj",
98
"Web/Web.csproj",
109
"Func/Func.csproj"

0 commit comments

Comments
 (0)