Skip to content

Commit 737f537

Browse files
Make conditional for now since there are too many bugs
I'll get this code merged since I think it's a good foundation for future work on this
1 parent b1dc452 commit 737f537

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

ICSharpCode.CodeConverter/CSharp/DocumentExtensions.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,12 @@ public static async Task<Document> WithExpandedRootAsync(this Document document)
4141
? (Func<SemanticModel, SyntaxNode, bool>)ShouldExpandVbNode
4242
: ShouldExpandCsNode;
4343
document = await WorkaroundBugsInExpandVbAsync(document, shouldExpand);
44+
45+
#if SimplifierBugsAreFixed //See https://github.com/icsharpcode/CodeConverter/pull/449 and https://github.com/icsharpcode/CodeConverter/pull/464
4446
document = await ExpandVbAsync(document, shouldExpand);
45-
return await UndoVbExpansionsHardToReverseInCSharpSemanticModel(document);
47+
document = await UndoVbExpansionsHardToReverseInCSharpSemanticModel(document);
48+
#endif
49+
return document;
4650
}
4751

4852
private static async Task<Document> WorkaroundBugsInExpandVbAsync(Document document, Func<SemanticModel, SyntaxNode, bool> shouldExpand)

Tests/TestData/MultiFileCharacterization/VBToCSResults/ConvertWholeSolution/WindowsAppVb/My Project/MyNamespace.Dynamic.Designer.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tests/TestData/MultiFileCharacterization/VBToCSResults/ConvertWholeSolution/WindowsAppVb/WinformsDesignerTest.Designer.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)