Conversation
|
Local output: Previously, a single trx file was created. @Youssef1313 is it possible like before to create a single trx for the entire |
|
So far we don't have post-processing of artifacts, so it's a TRX per test assembly. But you could search for tools out there that merges TRX files, you may be able to find some third-party tools that do it. |
I switched to --results-directory - but the files are named quite ugly Is there a way to include the project name? |
|
@christophwille We don't yet have placeholders for <PropertyGroup Condition="'$(UseReportTrx)' == 'true'">
<TestingPlatformCommandLineArguments>$(TestingPlatformCommandLineArguments) --report-trx --report-trx-filename $(MSBuildProjectName)</TestingPlatformCommandLineArguments>
</PropertyGroup>Then test with Note I'm writing directly on GitHub so I could have errors. |
|
@siegfriedpammer is it a problem if the test-results files have funky names? I mean we know the biggest one is from ics.d. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for .NET 10’s Microsoft Testing Platform (MTP) runner, switches from a JUnit logger to a TRX logger, and updates CI to leverage the new dotnet test --report-trx workflow.
- Register MTP as the
dotnet testrunner indotnet.config - Update test projects to enable MTP entry points, set runtime identifiers, and replace
JunitXml.TestLoggerwithMicrosoft.Testing.Extensions.TrxReport - Revise GitHub Actions to invoke
dotnet test --report-trxand collect all.trxfiles
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet.config | Added [dotnet.test.runner] section to specify Microsoft.Testing.Platform |
| ILSpy.Tests/ILSpy.Tests.csproj | Enabled MTP, set RIDs, swapped test logger, removed legacy StartupObject |
| ILSpy.BamlDecompiler.Tests.csproj | Mirrored MTP enablement and logger swap |
| ICSharpCode.Decompiler.Tests.csproj | Added GenerateTestingPlatformEntryPoint, MTP props, and TRX logger |
| Directory.Packages.props | Removed JUnit logger package, added TRX logger package, bumped NUnit3TestAdapter |
| .github/workflows/build-ilspy.yml | Switched to dotnet test --report-trx, updated artifact and report patterns |
Comments suppressed due to low confidence (1)
.github/workflows/build-ilspy.yml:66
- The solution filename is referenced as
ilspy.sln, but the repository usesILSpy.sln. This case mismatch can cause failures on case-sensitive runners—update toILSpy.sln.
run: dotnet test --solution ilspy.sln --configuration ${{ matrix.configuration }} --no-build --report-trx --results-directory test-results/${{ matrix.configuration }}
…mDotnetTestSupport
siegfriedpammer
force-pushed
the
christophwille/net10mtp
branch
from
aa4759e to
1a41fd8
Compare
PoC see https://github.com/christophwille/poc-oh/tree/main/src/MTPEntrypoint
Docs
Using trx extension because c6b6c09 switched from junit format to trx format.
Supersedes #3387
Optional in VS Preview