Replace FileVersionInfo.GetVersionInfo with DecompilerVersionInfo.Version constant #3667
+4
−3
Annotations
20 warnings
|
ICSharpCode.Decompiler/CSharp/Syntax/IAnnotatable.cs#L120
Do not lock on objects with weak identity (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2002)
|
|
ICSharpCode.Decompiler/CSharp/Syntax/TypeMembers/ExtensionDeclaration.cs#L27
get_SymbolKind creates an exception of type NotImplementedException, an exception type that should not be raised in a property. If this exception instance might be raised, use a different exception type, convert this property into a method, or change this property's logic so that it no longer raises an exception. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1065)
|
|
ICSharpCode.Decompiler/Util/LongSet.cs#L31
Implement the equality operators and make their behavior identical to that of the Equals method (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2231)
|
|
ICSharpCode.Decompiler/Util/EmptyList.cs#L102
Rename 'EmptyList.System.IDisposable.Dispose' to 'Dispose' and ensure that it is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Util/EmptyList.cs#L102
Ensure that 'EmptyList.System.IDisposable.Dispose' is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Util/ResXResourceWriter.cs#L307
Ensure that 'ResXResourceWriter.Dispose' is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Util/ResourcesFile.cs#L34
Provide an overridable implementation of Dispose(bool) on 'ResourcesFile' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Metadata/DotNetCorePathFinder.cs#L33
Move pinvokes to native methods class (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1060)
|
|
ICSharpCode.Decompiler/Metadata/PEFile.cs#L34
Provide an overridable implementation of Dispose(bool) on 'PEFile' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Metadata/WebCilFile.cs#L35
Provide an overridable implementation of Dispose(bool) on 'WebCilFile' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Util/LongSet.cs#L367
GetHashCode creates an exception of type NotImplementedException. Exceptions should not be raised in this type of method. If this exception instance might be raised, change this method's logic so it no longer raises an exception. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1065)
|
|
ICSharpCode.Decompiler/Output/PlainTextOutput.cs#L31
Type 'PlainTextOutput' owns disposable field(s) 'writer' but is not disposable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1001)
|
|
ICSharpCode.Decompiler/Metadata/PEFile.cs#L34
Provide an overridable implementation of Dispose(bool) on 'PEFile' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Metadata/DotNetCorePathFinder.cs#L33
Move pinvokes to native methods class (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1060)
|
|
ICSharpCode.Decompiler/Metadata/WebCilFile.cs#L35
Provide an overridable implementation of Dispose(bool) on 'WebCilFile' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Util/LongSet.cs#L31
Implement the equality operators and make their behavior identical to that of the Equals method (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2231)
|
|
ICSharpCode.Decompiler/Util/EmptyList.cs#L102
Rename 'EmptyList.System.IDisposable.Dispose' to 'Dispose' and ensure that it is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Util/EmptyList.cs#L102
Ensure that 'EmptyList.System.IDisposable.Dispose' is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Util/ResXResourceWriter.cs#L307
Ensure that 'ResXResourceWriter.Dispose' is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
ICSharpCode.Decompiler/Util/ResourcesFile.cs#L34
Provide an overridable implementation of Dispose(bool) on 'ResourcesFile' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
The logs for this run have expired and are no longer available.
Loading