Skip to content

Replace FileVersionInfo.GetVersionInfo with DecompilerVersionInfo.Version constant #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siegfriedpammer merged 2 commits into from
Feb 24, 2026
+4 −3
Merged

Replace FileVersionInfo.GetVersionInfo with DecompilerVersionInfo.Version constant #3667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a5c1ad
Update PortablePdbWriter.cs
MattParkerDev Feb 22, 2026
5bb8d7e
create constant
MattParkerDev Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ICSharpCode.Decompiler/DebugInfo/PortablePdbWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ namespace ICSharpCode.Decompiler.DebugInfo
{
public class PortablePdbWriter
{
static readonly FileVersionInfo decompilerVersion = FileVersionInfo.GetVersionInfo(typeof(CSharpDecompiler).Assembly.Location);
const string decompilerVersion = DecompilerVersionInfo.Version;

public static bool HasCodeViewDebugDirectoryEntry(PEFile file)
{
Expand Down Expand Up @@ -119,7 +119,7 @@ string BuildFileNameFromTypeName(TypeDefinitionHandle handle)

// Generate source and checksum
if (!noLogo)
syntaxTree.InsertChildAfter(null, new Comment(" PDB and source generated by ICSharpCode.Decompiler " + decompilerVersion.FileVersion), Roles.Comment);
syntaxTree.InsertChildAfter(null, new Comment(" PDB and source generated by ICSharpCode.Decompiler " + decompilerVersion), Roles.Comment);
var sourceText = SyntaxTreeToString(syntaxTree, settings);

// Generate sequence points for the syntax tree
Expand Down
2 changes: 1 addition & 1 deletion ICSharpCode.Decompiler/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// If you need to expose a type to COM, use [ComVisible(true)] on that type.
[assembly: ComVisible(false)]

[assembly: AssemblyVersion(DecompilerVersionInfo.Major + "." + DecompilerVersionInfo.Minor + "." + DecompilerVersionInfo.Build + "." + DecompilerVersionInfo.Revision)]
[assembly: AssemblyVersion(DecompilerVersionInfo.Version)]
[assembly: AssemblyInformationalVersion(DecompilerVersionInfo.FullVersionWithCommitHash)]

[assembly: InternalsVisibleTo("ICSharpCode.Decompiler.Tests, PublicKey=00240000048000009400000006020000002400005253413100040000010001004dcf3979c4e902efa4dd2163a039701ed5822e6f1134d77737296abbb97bf0803083cfb2117b4f5446a217782f5c7c634f9fe1fc60b4c11d62c5b3d33545036706296d31903ddcf750875db38a8ac379512f51620bb948c94d0831125fbc5fe63707cbb93f48c1459c4d1749eb7ac5e681a2f0d6d7c60fa527a3c0b8f92b02bf")]
Expand Down
1 change: 1 addition & 0 deletions ICSharpCode.Decompiler/Properties/DecompilerVersionInfo.template.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ public static class DecompilerVersionInfo
public const string Revision = "$INSERTREVISION$";
public const string VersionName = "preview3";

public const string Version = Major + "." + Minor + "." + Build + "." + Revision;
public const string FullVersion = Major + "." + Minor + "." + Build + ".$INSERTREVISION$$INSERTBRANCHPOSTFIX$$INSERTVERSIONNAMEPOSTFIX$";
public const string FullVersionWithShortCommitHash = FullVersion + "+$INSERTSHORTCOMMITHASH$";
public const string FullVersionWithCommitHash = FullVersion + "+$INSERTCOMMITHASH$";
Expand Down
Loading