Generate version-info files with CRLF on all platforms#3907
Merged
Conversation
update-assemblyinfo.ps1 joined the template lines with Environment.NewLine, so on Linux the generated DecompilerVersionInfo.cs was written with LF and the pre-commit format hook re-flagged all of its lines on every single commit. The repo's .cs files are CRLF; write the generated file that way regardless of platform, and compare with the same separator so the up-to-date check stays consistent. Assisted-by: Claude:claude-fable-5:Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update-assemblyinfo.ps1 joins the template lines with
Environment.NewLine, so on Linux the generatedDecompilerVersionInfo.csis written with LF. The repo's.csfiles are CRLF, so the pre-commit format hook re-flags every line of the generated file on each commit made on a Linux machine ("Formatted 1 of N files" on every run).Write the generated file with CRLF regardless of platform, and use the same separator in the up-to-date comparison so the change detection stays consistent. After the fix the hook reports "Formatted 0 of 1697 files" on Linux.
🤖 Generated with Claude Code