Fixed some issues with formatting options becoming "dirty" unnecessarily.

Author: Rpinski

src/AddIns/BackendBindings/CSharpBinding/Project/Src/FormattingStrategy/CSharpFormattingOptionsContainer.cs

@@ -127,7 +127,7 @@ private void HandlePropertyChanged(object sender, PropertyChangedEventArgs e)
 			if ((e.PropertyName == "Parent") || (e.PropertyName == null)) {
 				// All properties might have changed -> update everything
 				cachedOptions = CreateCachedOptions();
-				OnPropertyChanged(e.PropertyName);
+//				OnPropertyChanged(e.PropertyName);
 			} else {
 				// Some other property has changed, check if we have our own value for it
 				if (!activeOptions.Contains(e.PropertyName)) {
@@ -136,7 +136,7 @@ private void HandlePropertyChanged(object sender, PropertyChangedEventArgs e)
 					if (propertyInfo != null) {
 						var val = GetEffectiveOption(e.PropertyName);
 						propertyInfo.SetValue(cachedOptions, val);
-						OnPropertyChanged(e.PropertyName);
+//						OnPropertyChanged(e.PropertyName);
 					}
 				}
 			}
@@ -265,14 +265,16 @@ public void Load(Properties parentProperties)
 			if (parentProperties == null)
 				throw new ArgumentNullException("parentProperties");
 
-			Properties formatProperties = parentProperties.NestedProperties("CSharpFormatting");
-			if (formatProperties != null) {
-				foreach (var key in formatProperties.Keys) {
-					try {
-						object val = formatProperties.Get(key, (object) null);
-						SetOption(key, val);
-					} catch (Exception) {
-						// Silently ignore loading error, then this property will be "as parent" automatically
+			if (parentProperties.Contains("CSharpFormatting")) {
+				Properties formatProperties = parentProperties.NestedProperties("CSharpFormatting");
+				if (formatProperties != null) {
+					foreach (var key in formatProperties.Keys) {
+						try {
+							object val = formatProperties.Get(key, (object)null);
+							SetOption(key, val);
+						} catch (Exception) {
+							// Silently ignore loading error, then this property will be "as parent" automatically
+						}
 					}
 				}
 			}

src/AddIns/BackendBindings/CSharpBinding/Project/Src/OptionPanels/CSharpFormattingOptionPanel.xaml.cs

@@ -64,13 +64,15 @@ public CSharpSolutionFormattingOptionPanel()
 	internal partial class CSharpFormattingOptionPanel : OptionPanel
 	{
 		readonly CSharpFormattingOptionsPersistence persistenceHelper;
+		bool isDirty;
 
 		public CSharpFormattingOptionPanel(CSharpFormattingOptionsPersistence persistenceHelper, bool allowPresets)
 		{
 			if (persistenceHelper == null)
 				throw new ArgumentNullException("persistenceHelper");
 
 			this.persistenceHelper = persistenceHelper;
+			this.isDirty = false;
 			InitializeComponent();			
 
 			formattingEditor.AllowPresets = allowPresets;
@@ -79,12 +81,18 @@ public CSharpFormattingOptionPanel(CSharpFormattingOptionsPersistence persistenc
 		public override void LoadOptions()
 		{
 			base.LoadOptions();
-			formattingEditor.OptionsContainer = persistenceHelper.StartEditing(); 
+			formattingEditor.OptionsContainer = persistenceHelper.StartEditing();
+			formattingEditor.OptionsContainer.PropertyChanged += (sender, e) => isDirty = true;
 		}
 
 		public override bool SaveOptions()
 		{
-			return persistenceHelper.Save() && base.SaveOptions();
+			if (isDirty) {
+				return persistenceHelper.Save() && base.SaveOptions();
+			} else {
+				// Nothing has been changed here, return without action
+				return true;
+			}
 		}
 	}
 }