feat: ✨ User Free Times Aggregation#299
Open
masterdabber wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/server/actions/availability/free-times/action.ts">
<violation number="1" location="src/server/actions/availability/free-times/action.ts:22">
P2: Overnight (cross-midnight) scheduled meetings are silently dropped. When `fromTime` > `toTime`, the `while (currentMinutes < endMinutes)` condition is immediately false, so no slots are generated. The existing `generateTimeBlocks` in `utils.ts` already handles this wrap-around case — consider reusing that logic or adding similar handling here (incrementing past midnight and adjusting the date for the next-day portion).</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/server/actions/availability/free-times/action.ts">
<violation number="1" location="src/server/actions/availability/free-times/action.ts:23">
P1: Bug: Using `<=` instead of `<` causes a zero-duration scheduled block (where `fromTime === toTime`) to be expanded into a full 24-hour set of slots. This would incorrectly mark an entire day as "scheduled", removing all of the user's free times for that day. Use strict `<` to only trigger midnight-wrapping when the end time is genuinely before the start time.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Member
|
Is this PR ready for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR gets the user's free times where they have said they are available and they do not have a meeting scheduled.
Process:
Gets all user availabilities from all their meetings.
Finds the times that they have a scheduled meeting.
Then calculates all the times when they are available but do not have a meeting scheduled.
Added:
Querying the availabilities table for all availabilities of a single user
Querying the scheduled meetings table for all scheduled timings of a single user
Made a server action that converts scheduled meetings into 15-min blocks to compare with availabilities.
Returns:
All free times in the format of availabilities of 15 min blocks as UTC ISO strings in ascending order.
or
Error, if unable to complete process