Skip to content

Commit 2c7e33f

Browse files
mannkafaiMartin KaFai Lau
authored andcommitted
selftests/bpf: Verify bpf-tcp-cc rejects TCP_NODELAY
Add a bpf_tcp_ca selftest for the TCP_NODELAY restriction in bpf-tcp-cc. Update bpf_cubic to exercise init() and cwnd_event_tx_start(), and check that both callbacks reject bpf_setsockopt(TCP_NODELAY) with -EOPNOTSUPP. Signed-off-by: KaFai Wan <kafai.wan@linux.dev> Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org> Link: https://patch.msgid.link/20260421155804.135786-5-kafai.wan@linux.dev
1 parent 52b6b53 commit 2c7e33f

2 files changed

Lines changed: 18 additions & 0 deletions

File tree

tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,10 @@ static void test_cubic(void)
112112

113113
ASSERT_EQ(cubic_skel->bss->bpf_cubic_acked_called, 1, "pkts_acked called");
114114

115+
ASSERT_TRUE(cubic_skel->bss->nodelay_init_reject, "init reject nodelay option");
116+
ASSERT_TRUE(cubic_skel->bss->nodelay_cwnd_event_tx_start_reject,
117+
"cwnd_event_tx_start reject nodelay option");
118+
115119
bpf_link__destroy(link);
116120
bpf_cubic__destroy(cubic_skel);
117121
}

tools/testing/selftests/bpf/progs/bpf_cubic.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
#include "bpf_tracing_net.h"
1818
#include <bpf/bpf_tracing.h>
19+
#include <errno.h>
1920

2021
char _license[] SEC("license") = "GPL";
2122

@@ -170,10 +171,18 @@ static void bictcp_hystart_reset(struct sock *sk)
170171
ca->sample_cnt = 0;
171172
}
172173

174+
bool nodelay_init_reject = false;
175+
bool nodelay_cwnd_event_tx_start_reject = false;
176+
173177
SEC("struct_ops")
174178
void BPF_PROG(bpf_cubic_init, struct sock *sk)
175179
{
176180
struct bpf_bictcp *ca = inet_csk_ca(sk);
181+
int true_val = 1, ret;
182+
183+
ret = bpf_setsockopt(sk, SOL_TCP, TCP_NODELAY, &true_val, sizeof(true_val));
184+
if (ret == -EOPNOTSUPP)
185+
nodelay_init_reject = true;
177186

178187
bictcp_reset(ca);
179188

@@ -189,8 +198,13 @@ void BPF_PROG(bpf_cubic_cwnd_event_tx_start, struct sock *sk)
189198
{
190199
struct bpf_bictcp *ca = inet_csk_ca(sk);
191200
__u32 now = tcp_jiffies32;
201+
int true_val = 1, ret;
192202
__s32 delta;
193203

204+
ret = bpf_setsockopt(sk, SOL_TCP, TCP_NODELAY, &true_val, sizeof(true_val));
205+
if (ret == -EOPNOTSUPP)
206+
nodelay_cwnd_event_tx_start_reject = true;
207+
194208
delta = now - tcp_sk(sk)->lsndtime;
195209

196210
/* We were application limited (idle) for a while.

0 commit comments

Comments
 (0)