Switch from Jest to Vitest#297
Merged
Merged
Conversation
Collaborator
|
I would say |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align with iD, see openstreetmap/iD#10452.
As a side-effect, the total number of dependencies goes down from 412 to 245 (-41%) and with that a vulnerability in the no longer needed transitive
brace-expansiondependency is resolved.For the coverage provider, we have two choices:
Keeps the reported coverage exactly the same as with Jest (as that also used Istanbul), but increases the test duration from ~0.43s to ~0.89s on my machine.
Reports slightly larger coverage in
build.jsthan Jest/Istanbul (74.12% vs. 73.77% statements, 64.10% vs. 63.78% branches), exactly the same coverage in the other files, but keeps test duration at ~0.49s on my machine.I'm happy to switch to v8 if preferred.