Skip to content

Add Pinhead as icon source. #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrasd merged 5 commits into from
May 19, 2026
Merged

Add Pinhead as icon source. #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d021920
Add Pinhead as icon source.
matkoniecz May 12, 2026
11f49b6
tweak wording
tyrasd May 12, 2026
a508d67
Better Pinhead link
matkoniecz May 14, 2026
60acdc8
fix link
matkoniecz May 14, 2026
4281b48
specify icon source
matkoniecz May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* :warning: Add _integer_ field type ([#217], thanks [@k-yle])
* :warning: Store `terms` and `aliases` as an array in the translation files ([#227], thanks [@k-yle])
* :warning: Support discarding tags, not just keys ([#231], thanks [@k-yle])
* :warning: Pinhead icon set is allowed as an additional source for icons ([#300], thanks [@matkoniecz])

###### Non-breaking changes, which affect consumers

Expand Down
1 change: 1 addition & 0 deletions ICONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Icons from the below listed sources can be used. When specifying an icon, use th
| [Font Awesome Solid](https://fontawesome.com/search?o=r&ic=free&s=solid) | `fas-` | Solid style icons from Font Awesome (free tier) | [Preview](https://icones.js.org/collection/fa7-solid) |
| [Font Awesome Regular](https://fontawesome.com/search?o=r&ic=free&s=regular) | `far-` | Regular style icons from Font Awesome (free tier) | [Preview](https://icones.js.org/collection/fa7-regular) |
| [Font Awesome Brands](https://fontawesome.com/search?o=r&ic=free&ip=brands) | `fab-` | Brand icons from Font Awesome (free tier) | [Preview](https://icones.js.org/collection/fa7-brands) |
| [Pinhead](https://pinhead.ink/) | `pinhead-` | Public domain icons for map pins | [Preview](https://pinhead.ink/) |
Copy link
Copy Markdown
Contributor Author

@matkoniecz matkoniecz May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matching preview link blocked by iconify/icon-sets#304

Copy link
Copy Markdown
Contributor Author

@matkoniecz matkoniecz May 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added (with comment "Really good set"), new release of icones not done yet I guess as it is not on the live site

iconify/icon-sets@540c25d

TODO: check in few hours/days: https://icones.js.org/collection/pinhead https://icones.js.org/

| [iD Presets](https://github.com/openstreetmap/iD/tree/develop/svg/iD-sprite/presets) | `iD-` | iD's presets-icons | - |
| [iD Fields](https://github.com/openstreetmap/iD/tree/develop/svg/iD-sprite/fields) | `iD-` | iD's fields-icons | - |

Expand Down
14 changes: 11 additions & 3 deletions MIGRATION_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# v7 Migration Guide

v7 of [id-tagging-schema](https://github.com/openstreetmap/id-tagging-schema) and [schema-builder](https://github.com/ideditor/schema-builder) contains 5 breaking changes, where data consumers will need to take action.
v7 of [id-tagging-schema](https://github.com/openstreetmap/id-tagging-schema) and [schema-builder](https://github.com/ideditor/schema-builder) contains 6 breaking changes, where data consumers will need to take action.

This document is a brief migration guide.
The full list of changes is in [CHANGELOG.md](./CHANGELOG.md).
Expand Down Expand Up @@ -117,7 +117,15 @@ Any other values of the `attribution` tag should NOT be discarded.
> [!IMPORTANT]
> Action Required: If you use this file, ensure that your code handles the new format.

## 6. No more references ([#281](https://github.com/ideditor/schema-builder/pull/281))
## 6. New icon set ([#300](https://github.com/ideditor/schema-builder/pull/300))

`pinhead-` prefixed icon codes are now allowed and point to [https://pinhead.ink/](https://pinhead.ink/) project. Support for one more icon set should be added.

Icons can be obtained from `https://pinhead.ink/latest/{ID}.svg` for `pinhead-{ID}` icon reference.

See also [bundling proposal](https://github.com/openstreetmap/id-tagging-schema/issues/2208) considered to be added in future (feedback welcome).

## 7. No more references ([#281](https://github.com/ideditor/schema-builder/pull/281))

If you currently parse the fields `stringsCrossReference` or `iconsCrossReference`, or if you handle the reference syntax (such as `"{natural/beach}"`), all this logic can be now be deleted.

Expand All @@ -129,6 +137,6 @@ It also allows iD-tagging-schema to implement new internal referencing logic (su
> [!IMPORTANT]
> Action Required: None. Optionally, you could delete this logic from your code.

## 7. Other changes
## 8. Other changes

See the [CHANGELOG.md](./CHANGELOG.md) file for the 3 other non-breaking changes to the schema.
3 changes: 3 additions & 0 deletions lib/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,9 @@ function generateTaginfo(presets, fields, deprecated, discarded, tstrings, proje
} else if (/^fa[srb]-/.test(preset.icon)) {
tag.icon_url = 'https://cdn.jsdelivr.net/gh/openstreetmap/iD@develop/svg/fontawesome/' +
preset.icon + '.svg';
} else if (/^pinhead-/.test(preset.icon)) {
tag.icon_url = 'https://pinhead.ink/latest/' +
preset.icon.replace(/^pinhead-/, '') + '.svg';
} else if (/^iD-/.test(preset.icon)) {
tag.icon_url = 'https://cdn.jsdelivr.net/gh/openstreetmap/iD@develop/svg/iD-sprite/presets/' +
preset.icon.replace(/^iD-/, '') + '.svg';
Expand Down