fix(fallow): suppress oxc-minify false positive and fix duplicates override#167
Merged
Conversation
…erride
The oxc-minify dependency is required transitively by VitePress via
rolldown-vite, but is not directly imported by our code. Add it to
ignoreDependencies to suppress the false positive.
The previous [[overrides]] section used rules = { duplicates = 'off' },
which Fallow warns is an unknown rule name. Replace it with a proper
[duplicates] section using the ignore key, which is the correct TOML
config for suppressing duplication detection in specific file patterns.
Closes #146
Deploying idempot-js with
|
| Latest commit: |
c6e063b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4d9d1d03.idempot-js.pages.dev |
| Branch Preview URL: | https://fix-fallow-config-146.idempot-js.pages.dev |
mroderick
marked this pull request as ready for review
June 13, 2026 17:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues in
fallow.tomlthat caused Fallow warnings or false positives.Changes
1. Suppress
oxc-minifyfalse positiveThe
oxc-minifydependency was added in5fca2ffas a transitive dependency required by VitePress via rolldown-vite. Fallow correctly reports it as an unused devDependency because no source file directly imports it. Add it toignoreDependenciesto suppress the false positive.2. Fix invalid
duplicatesoverrideThe previous
[[overrides]]section usedrules = { duplicates = "off" }, which Fallow warns is an unknown rule name:Replace it with a proper
[duplicates]section using theignorekey, which is the correct TOML config for suppressing duplication detection in specific file patterns.Verification
npx fallow dead-code # ✓ No issues found (0.08s)Closes #146