Skip to content

first pass update to known-1.0.0/php7.3#12

Open
edrex wants to merge 1 commit into
idno:masterfrom
edrex:known-1.0.0
Open

first pass update to known-1.0.0/php7.3#12
edrex wants to merge 1 commit into
idno:masterfrom
edrex:known-1.0.0

Conversation

@edrex

@edrex edrex commented Nov 13, 2019

Copy link
Copy Markdown

It builds but is untested.

Issues:

  • Uses tar from @mapkyca's site, is that final?
  • Couldn't figure out what to do with the binary .sha256. Isn't it supposed to be in hex? Also the key you have linked at https://www.marcus-povey.co.uk/known/ (EC8148CF845C2043948FFF81BACB0C9AAA54ED56) isn't the signing key (E3F1C15C43A1E393A4B88C6E20FD53C2397813CA)

Changes:

  • Mariadb client since no mysql in buster
  • mcrypt moved to pecl

I know nothing about modern PHP so please advise what else should be changed,
or just fix this up for me :D

@mapkyca

mapkyca commented Nov 13, 2019

Copy link
Copy Markdown
Member

Ooopsy, I think I had the package built using my personal key. I'll update the key when I get back.

Thanks for this, I'll take a look at it later...

@edrex

edrex commented Nov 13, 2019

Copy link
Copy Markdown
Author

Would it be better to use uncomposed tars from github like https://github.com/egoexpress/docker-known/blob/master/Dockerfile? Could set up a builder for master too that way..

@mapkyca

mapkyca commented Nov 14, 2019

Copy link
Copy Markdown
Member

Depends on what you're wanting to achieve. If you want to containerise a "release", then use the package. If you want to containerise the bleeding edge code then use a git checkout + composer.

I can see an argument for having both options available, and I for one would find it useful to have a docker image of bleeding edge Known. Especially if it was configured to better mimic a "real world" deploy - e.g. database in a separate container to web, ditto files

@mapkyca

mapkyca commented Jan 5, 2020

Copy link
Copy Markdown
Member

PHP 7.4 is now out, so I'd suggest packaging for that as well

@edrex

edrex commented Jan 9, 2020

Copy link
Copy Markdown
Author

Sorry, I haven't gotten back to this and need to focus on other things right now. Feel free to fix up or I'll get to it when I next work on my known blog. 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants