first pass update to known-1.0.0/php7.3#12
Conversation
|
Ooopsy, I think I had the package built using my personal key. I'll update the key when I get back. Thanks for this, I'll take a look at it later... |
|
Would it be better to use uncomposed tars from github like https://github.com/egoexpress/docker-known/blob/master/Dockerfile? Could set up a builder for master too that way.. |
|
Depends on what you're wanting to achieve. If you want to containerise a "release", then use the package. If you want to containerise the bleeding edge code then use a git checkout + composer. I can see an argument for having both options available, and I for one would find it useful to have a docker image of bleeding edge Known. Especially if it was configured to better mimic a "real world" deploy - e.g. database in a separate container to web, ditto files |
|
PHP 7.4 is now out, so I'd suggest packaging for that as well |
|
Sorry, I haven't gotten back to this and need to focus on other things right now. Feel free to fix up or I'll get to it when I next work on my known blog. 🤦♂️ |
It builds but is untested.
Issues:
Changes:
I know nothing about modern PHP so please advise what else should be changed,
or just fix this up for me :D