perf: convert update() from METH_VARARGS to METH_O

METH_O passes the single argument directly without tuple allocation.
Also eliminates PyArg_ParseTuple overhead for the common single-arg case.

Author: ifduyue

src/_xxhash.c

@@ -574,15 +574,12 @@ PyDoc_STRVAR(
     "Update the xxh32 object with the string data. Repeated calls are\n"
     "equivalent to a single call with the concatenation of all the arguments.");
 
-static PyObject *PYXXH32_update(PYXXH32Object *self, PyObject *args)
+static PyObject *PYXXH32_update(PYXXH32Object *self, PyObject *arg)
 {
     Py_buffer buf;
 
-    buf.buf = buf.obj = NULL;
-
-    if (!PyArg_ParseTuple(args, "y*:update", &buf)) {
+    if (PyObject_GetBuffer(arg, &buf, PyBUF_SIMPLE) < 0)
         return NULL;
-    }
 
     PYXXH32_do_update(self, &buf);
 
@@ -685,7 +682,7 @@ static PyObject *PYXXH32_reset(PYXXH32Object *self)
 }
 
 static PyMethodDef PYXXH32_methods[] = {
-    {"update", (PyCFunction)PYXXH32_update, METH_VARARGS, PYXXH32_update_doc},
+    {"update", (PyCFunction)PYXXH32_update, METH_O, PYXXH32_update_doc},
     {"digest", (PyCFunction)PYXXH32_digest, METH_NOARGS, PYXXH32_digest_doc},
     {"hexdigest", (PyCFunction)PYXXH32_hexdigest, METH_NOARGS, PYXXH32_hexdigest_doc},
     {"intdigest", (PyCFunction)PYXXH32_intdigest, METH_NOARGS, PYXXH32_intdigest_doc},
@@ -930,15 +927,12 @@ PyDoc_STRVAR(
     "Update the xxh64 object with the string data. Repeated calls are\n"
     "equivalent to a single call with the concatenation of all the arguments.");
 
-static PyObject *PYXXH64_update(PYXXH64Object *self, PyObject *args)
+static PyObject *PYXXH64_update(PYXXH64Object *self, PyObject *arg)
 {
     Py_buffer buf;
 
-    buf.buf = buf.obj = NULL;
-
-    if (!PyArg_ParseTuple(args, "y*:update", &buf)) {
+    if (PyObject_GetBuffer(arg, &buf, PyBUF_SIMPLE) < 0)
         return NULL;
-    }
 
     PYXXH64_do_update(self, &buf);
 
@@ -1041,7 +1035,7 @@ static PyObject *PYXXH64_reset(PYXXH64Object *self)
 }
 
 static PyMethodDef PYXXH64_methods[] = {
-    {"update", (PyCFunction)PYXXH64_update, METH_VARARGS, PYXXH64_update_doc},
+    {"update", (PyCFunction)PYXXH64_update, METH_O, PYXXH64_update_doc},
     {"digest", (PyCFunction)PYXXH64_digest, METH_NOARGS, PYXXH64_digest_doc},
     {"hexdigest", (PyCFunction)PYXXH64_hexdigest, METH_NOARGS, PYXXH64_hexdigest_doc},
     {"intdigest", (PyCFunction)PYXXH64_intdigest, METH_NOARGS, PYXXH64_intdigest_doc},
@@ -1285,15 +1279,12 @@ PyDoc_STRVAR(
     "Update the xxh3_64 object with the string data. Repeated calls are\n"
     "equivalent to a single call with the concatenation of all the arguments.");
 
-static PyObject *PYXXH3_64_update(PYXXH3_64Object *self, PyObject *args)
+static PyObject *PYXXH3_64_update(PYXXH3_64Object *self, PyObject *arg)
 {
     Py_buffer buf;
 
-    buf.buf = buf.obj = NULL;
-
-    if (!PyArg_ParseTuple(args, "y*:update", &buf)) {
+    if (PyObject_GetBuffer(arg, &buf, PyBUF_SIMPLE) < 0)
         return NULL;
-    }
 
     PYXXH3_64_do_update(self, &buf);
 
@@ -1404,7 +1395,7 @@ static PyObject *PYXXH3_64_reset(PYXXH3_64Object *self)
 }
 
 static PyMethodDef PYXXH3_64_methods[] = {
-    {"update", (PyCFunction)PYXXH3_64_update, METH_VARARGS, PYXXH3_64_update_doc},
+    {"update", (PyCFunction)PYXXH3_64_update, METH_O, PYXXH3_64_update_doc},
     {"digest", (PyCFunction)PYXXH3_64_digest, METH_NOARGS, PYXXH3_64_digest_doc},
     {"hexdigest", (PyCFunction)PYXXH3_64_hexdigest, METH_NOARGS, PYXXH3_64_hexdigest_doc},
     {"intdigest", (PyCFunction)PYXXH3_64_intdigest, METH_NOARGS, PYXXH3_64_intdigest_doc},
@@ -1649,14 +1640,12 @@ PyDoc_STRVAR(
     "Update the xxh3_128 object with the string data. Repeated calls are\n"
     "equivalent to a single call with the concatenation of all the arguments.");
 
-static PyObject *PYXXH3_128_update(PYXXH3_128Object *self, PyObject *args)
+static PyObject *PYXXH3_128_update(PYXXH3_128Object *self, PyObject *arg)
 {
     Py_buffer buf;
-    buf.buf = buf.obj = NULL;
 
-    if (!PyArg_ParseTuple(args, "y*:update", &buf)) {
+    if (PyObject_GetBuffer(arg, &buf, PyBUF_SIMPLE) < 0)
         return NULL;
-    }
 
     PYXXH3_128_do_update(self, &buf);
 
@@ -1785,7 +1774,7 @@ static PyObject *PYXXH3_128_reset(PYXXH3_128Object *self)
 }
 
 static PyMethodDef PYXXH3_128_methods[] = {
-    {"update", (PyCFunction)PYXXH3_128_update, METH_VARARGS, PYXXH3_128_update_doc},
+    {"update", (PyCFunction)PYXXH3_128_update, METH_O, PYXXH3_128_update_doc},
     {"digest", (PyCFunction)PYXXH3_128_digest, METH_NOARGS, PYXXH3_128_digest_doc},
     {"hexdigest", (PyCFunction)PYXXH3_128_hexdigest, METH_NOARGS, PYXXH3_128_hexdigest_doc},
     {"intdigest", (PyCFunction)PYXXH3_128_intdigest, METH_NOARGS, PYXXH3_128_intdigest_doc},