Faster CI#3411
Conversation
📝 WalkthroughWalkthroughThe CI workflow gains a dedicated 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Since Windows and macOS builds are slower, and all tests rely on ubuntu, this enables tests to begin ~10 minutes sooner
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/continuous-integration-workflow.yml:
- Line 1254: The affected workflow jobs currently depend on build-matrix and
related checks but not on build, so they can run before the Linux 17 artifact is
produced. Update the needs lists for the downstream jobs referenced here and in
the other matching workflow entries to include build alongside build-matrix,
ensuring the new build job completes before any job that consumes its output or
downloads the Debian artifact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5af34a0e-780c-4039-8ff9-b3c8fec7005c
📒 Files selected for processing (1)
.github/workflows/continuous-integration-workflow.yml
|
Thanks for this. I think another cause for the slow builds are these changes: d49cce2 I'm not sure if they're still needed, or, if they are, can be made more robust. |
|
I'd rather not touch that as part of this. This is entirely GHA shenanigans. |
|
I like the idea of splitting the ubuntu/JDK17 build out of the matrix so downstream jobs no longer need to wait for the full matrix to complete, speeding up the entire workflow. My only concern is that we've now duplicated almost the entire build job. As the workflow evolves, it's almost guaranteed for the two implementations to drift apart. Could we extract the common build steps into either a reusable workflow or a composite action, and have both build and build-matrix invoke that? That would preserve the optimization, while keeping the build logic defined in one place. |
This gets developer feedback sooner.