From d4f2d4ae1b69c42f3dca6a314bd0ba4df8d7c9bf Mon Sep 17 00:00:00 2001 From: Micha Kurvers Date: Fri, 17 Oct 2025 16:22:10 +0200 Subject: [PATCH 1/2] Fix assembly build (Assembly.xml assumes the plugin.xml, changelog.html and reade.html to be two dirs above the src/main/java folder) --- changelog.html => src/changelog.html | 0 plugin.xml => src/plugin.xml | 0 readme.html => src/readme.html | 0 3 files changed, 0 insertions(+), 0 deletions(-) rename changelog.html => src/changelog.html (100%) rename plugin.xml => src/plugin.xml (100%) rename readme.html => src/readme.html (100%) diff --git a/changelog.html b/src/changelog.html similarity index 100% rename from changelog.html rename to src/changelog.html diff --git a/plugin.xml b/src/plugin.xml similarity index 100% rename from plugin.xml rename to src/plugin.xml diff --git a/readme.html b/src/readme.html similarity index 100% rename from readme.html rename to src/readme.html From 2f82e7a44666fde26157964b3c4e430bab2d97eb Mon Sep 17 00:00:00 2001 From: Micha Kurvers Date: Fri, 17 Oct 2025 16:22:29 +0200 Subject: [PATCH 2/2] Set field type to text_multi when extension field contains multiple values --- .../mucextinfo/DiscoInfoProviderProxy.java | 16 ++++++++++++---- .../DiscoInfoProviderProxyMergeTest.java | 3 +-- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/igniterealtime/openfire/plugin/mucextinfo/DiscoInfoProviderProxy.java b/src/main/java/org/igniterealtime/openfire/plugin/mucextinfo/DiscoInfoProviderProxy.java index a09e01e..2eda3be 100644 --- a/src/main/java/org/igniterealtime/openfire/plugin/mucextinfo/DiscoInfoProviderProxy.java +++ b/src/main/java/org/igniterealtime/openfire/plugin/mucextinfo/DiscoInfoProviderProxy.java @@ -127,21 +127,29 @@ static Set merge( @Nullable Set 1; + } } diff --git a/src/test/java/org/igniterealtime/openfire/plugin/mucextinfo/DiscoInfoProviderProxyMergeTest.java b/src/test/java/org/igniterealtime/openfire/plugin/mucextinfo/DiscoInfoProviderProxyMergeTest.java index daea5cc..6e7039b 100644 --- a/src/test/java/org/igniterealtime/openfire/plugin/mucextinfo/DiscoInfoProviderProxyMergeTest.java +++ b/src/test/java/org/igniterealtime/openfire/plugin/mucextinfo/DiscoInfoProviderProxyMergeTest.java @@ -19,11 +19,9 @@ import org.xmpp.forms.DataForm; import org.xmpp.forms.FormField; -import java.util.ArrayList; import java.util.HashSet; import java.util.List; import java.util.Set; -import java.util.concurrent.ConcurrentMap; import static org.junit.Assert.*; @@ -224,6 +222,7 @@ public void testOriginalWithExtensionSameFormSameFieldDifferentValue() assertEquals( 2, resultFields.size() ); // should contain the field we added, as well as a 'FORM_TYPE' field. assertTrue( resultFields.stream().anyMatch( formField -> "origvar".equals( formField.getVariable() ) && "origlabel".equals( formField.getLabel() ) + && formField.getType().equals(FormField.Type.text_multi) && formField.getValues().contains( "origvalue") && formField.getValues().contains( "extvalue") && formField.getValues().size() == 2